Uh oh!
There was an error while loading. Please reload this page.
test: improve multiple timers tests - #14616
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
jasnellforce-pushed
the
improve-timers-tests
branch
from
August 4, 2017 01:10
2840276 to
94cd7f2Comparejasnell
commented
Aug 4, 2017
MemberAuthor
addaleax
commented
Aug 4, 2017
Member
@jasnell not before Monday. ;) |
jasnell
commented
Aug 4, 2017
MemberAuthor
No worries! :-) enjoy your weekend! |
addaleax
approved these changes
Aug 7, 2017
refack
approved these changes
Aug 7, 2017
| console.error('[FAIL] Interval fired %d/%d times.', nbIntervalFired, N); | ||
| throw new Error('Test timed out. keepOpen was not canceled.'); | ||
| }, TEST_DURATION); | ||
| const keepOpen = |
Contributor
There was a problem hiding this comment.
nit: This is an uncommon wrapping, IMHO
constkeepOpen=setTimeout(common.mustNotCall('Test timed out. keepOpen was not canceled.'),TEST_DURATION);is more "regular".
Alltought
constkeepOpenMsg='Test timed out. keepOpen was not canceled.'constkeepOpen=setTimeout(common.mustNotCall(keepOpenMsg),TEST_DURATION);is usually my preference.
| { | ||
| let ncalled = 0; | ||
| let ncalled = 3; |
jasnell added a commit
that referenced
this pull request
Aug 8, 2017
PR-URL: #14616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell
commented
Aug 8, 2017
MemberAuthor
Landed in 7192e91 |
addaleax pushed a commit
that referenced
this pull request
Aug 10, 2017
PR-URL: #14616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 19, 2017
PR-URL: #14616 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General improvements to various timers tests
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tests