Skip to content

benchmark: Correct constructor for freelist - #14627

Closed
gareth-ellis wants to merge 1 commit into
nodejs:masterfrom
gareth-ellis:freelist
Closed

benchmark: Correct constructor for freelist#14627
gareth-ellis wants to merge 1 commit into
nodejs:masterfrom
gareth-ellis:freelist

Conversation

@gareth-ellis

Copy link
Copy Markdown
Member

Updates to use current constructor for freelist, which was changed
under pr #12644.

While setting up core benchmark tests in jenkins, i came across this benchmark that currently is broken in master.

This fixes the benchmark (functionally).

Checklist
Affected core subsystem(s)

benchmark

Updates to use current constructor for freelist, which was changed under pr #12644
@nodejs-github-botnodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 4, 2017
@jasnell

Copy link
Copy Markdown
Member

@addaleax

Copy link
Copy Markdown
Member

Landed in b5556e4, thank you!

addaleax pushed a commit that referenced this pull request Aug 10, 2017
Updates to use current constructor for freelist, which was changed
under pr #12644
Ref: #12644
PR-URL: #14627
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Aug 12, 2017
Updates to use current constructor for freelist, which was changed
under pr #12644
Ref: #12644
PR-URL: #14627
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@addaleaxaddaleax mentioned this pull request Aug 13, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

benchmarkIssues and PRs related to the benchmark subsystem.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@gareth-ellis@jasnell@addaleax@lpinca@cjihrig@gibfahn@MylesBorins@nodejs-github-bot