Uh oh!
There was an error while loading. Please reload this page.
doc: update AUTHORS list - #1476
Closed
rvagg wants to merge 6 commits into
Closed
Conversation
This commit: - fixes development branch (v1.x -> master) - updates stability index wording - use iojs binary instead of node PR-URL: nodejs#1466 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This reverts commit 06cfff9. Reverted because it introduced a regression where (because options were modified in the later functionality) options.host and options.port would be overridden with values provided in other, supported ways. PR-URL: nodejs#1467 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit adds a test to ensure all options are NOT modified after passing them to http.request. Specifically options.host and options.port are the most prominent that would previously error, but add the other options that have default values. options.host and options.port were overridden for the one-argument net.createConnection(options) call. PR-URL: nodejs#1467 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
commented
Apr 20, 2015
MemberAuthor
unsure if I should PR against v1.x or master |
bnoordhuis
commented
Apr 20, 2015
Member
LGTM and I'm not sure either. |
Fishrock123
commented
Apr 20, 2015
Contributor
Shouldn't it PR against what it was generated from? it should be 1.x until 1.8.1 ships, then split, I think? |
chrisdickinson
commented
Apr 20, 2015
Contributor
Anything you want in both v1.8.1 and v2.0.0 should go in v1.x for the time being. Once v1.8.1 is released I will merge v1.8.1 back into v2.0.0. |
This brings in the '%PYTHON%' revert, and restores the correct NODE_MODULE_VERSION. PR-URL: nodejs#1482 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Update AUTHORS list using tools/update-authors.sh PR-URL: nodejs#1476 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg
commented
Apr 21, 2015
MemberAuthor
landed @ 2632775 on master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update AUTHORS list using tools/update-authors.sh