Skip to content

[v8.x backport] encoding: rudimentary TextDecoder support w/o ICU - #14786

Closed
TimothyGu wants to merge 1 commit into
nodejs:v8.x-stagingfrom
TimothyGu:v8.x-14489
Closed

[v8.x backport] encoding: rudimentary TextDecoder support w/o ICU#14786
TimothyGu wants to merge 1 commit into
nodejs:v8.x-stagingfrom
TimothyGu:v8.x-14489

Conversation

@TimothyGu

@TimothyGuTimothyGu commented Aug 12, 2017

Copy link
Copy Markdown
Member

Also split up the tests.

PR-URL: #14489
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Refael Ackermann refack@gmail.com

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

encoding

@TimothyGu
encoding: rudimentary TextDecoder support w/o ICU
2ab406e
Also split up the tests.
PR-URL: nodejs#14489
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@TimothyGuTimothyGu added the encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. label Aug 12, 2017
@TimothyGu
TimothyGu requested a review from jasnellAugust 12, 2017 09:25
@nodejs-github-botnodejs-github-bot added encoding Issues and PRs related to the TextEncoder and TextDecoder APIs. errors Issues and PRs related to JavaScript errors originated in Node.js core. v8.x labels Aug 12, 2017
@TimothyGuTimothyGu mentioned this pull request Aug 12, 2017
Closed
3 tasks
@TimothyGu

TimothyGu commented Aug 12, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9625/

addaleax pushed a commit that referenced this pull request Aug 12, 2017
@TimothyGu@addaleax
encoding: rudimentary TextDecoder support w/o ICU
c5ee34e
Also split up the tests.
Backport-PR-URL: #14786
Backport-Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #14489
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@addaleax

addaleax commented Aug 12, 2017

Copy link
Copy Markdown
Member

Landed in c5ee34e, thanks for backporting!

@TimothyGu
TimothyGu deleted the v8.x-14489 branch March 26, 2018 02:28
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleaxaddaleaxaddaleax approved these changes
@jasnelljasnellAwaiting requested review from jasnell

Assignees

No one assigned

Labels

encodingIssues and PRs related to the TextEncoder and TextDecoder APIs.errorsIssues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimothyGu@addaleax@nodejs-github-bot