Uh oh!
There was an error while loading. Please reload this page.
[v6.x backport] tools: eslint - use error and off - #14841
Closed
refack wants to merge 1 commit into
Closed
Conversation
refackforce-pushed
the
backport-14061-to-v6.x
branch
from
August 15, 2017 17:47
ac9f02d to
c778371CompareMylesBorins
commented
Aug 16, 2017
Contributor
@refack this is going to need a rebase, there are some conflicts |
2 tasks
MylesBorinsforce-pushed
the
v6.x-staging
branch
2 times, most recently
from
August 16, 2017 18:43
f9419c2 to
403c465CompareMember
There was a problem hiding this comment.
Not sure why these changes are here?
MylesBorinsforce-pushed
the
v6.x-staging
branch
2 times, most recently
from
September 5, 2017 16:50
aaf4e13 to
31f572cCompareMylesBorins
commented
Sep 19, 2017
Contributor
@refack, rebase needed |
refackforce-pushed
the
backport-14061-to-v6.x
branch
from
September 19, 2017 13:32
c778371 to
233c91eComparerefack
commented
Sep 19, 2017
ContributorAuthor
@MylesBorins Rebased |
MylesBorins
commented
Sep 19, 2017
Contributor
oh geeze oh man... needs one more rebase (I guess I landed something in the last hour. Sorry |
PR-URL: nodejs#14061 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> # Conflicts: # .eslintrc.yaml # benchmark/.eslintrc.yaml # doc/.eslintrc.yaml # test/.eslintrc.yaml # tools/.eslintrc.yaml
refackforce-pushed
the
backport-14061-to-v6.x
branch
from
September 19, 2017 14:31
233c91e to
328f04cComparerefack
commented
Sep 19, 2017
ContributorAuthor
NP, the engine was still warm 😄 |
MylesBorins pushed a commit
that referenced
this pull request
Sep 19, 2017
Backport-PR-URL: #14841 PR-URL: #14061 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
commented
Sep 19, 2017
Contributor
landed in f7b6d19 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR-URL: #14061
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Vse Mozhet Byt vsemozhetbyt@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Franziska Hinkelmann franziska.hinkelmann@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Conflicts:
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools