Skip to content

doc: add BridgeAR to collaborators - #14862

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:add-me
Closed

doc: add BridgeAR to collaborators#14862
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:add-me

Conversation

@BridgeAR

@BridgeARBridgeAR commented Aug 16, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 16, 2017
Trott
Trott approved these changes Aug 16, 2017
View reviewed changes

@TrottTrott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BridgeAR

BridgeAR commented Aug 16, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9688/

@TrottTrott added the notable-change PRs with changes that should be highlighted in changelogs. label Aug 16, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request Aug 16, 2017
@BridgeAR
doc: add BridgeAR to collaborators
e9c0263
PR-URL: nodejs#14862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BridgeAR

BridgeAR commented Aug 16, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in e9c0263

@thefourtheye

thefourtheye commented Aug 16, 2017

Copy link
Copy Markdown
Contributor

Welcome @BridgeAR :-)

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@BridgeAR@MylesBorins
doc: add BridgeAR to collaborators
2b1a409
PR-URL: #14862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@BridgeAR@MylesBorins
doc: add BridgeAR to collaborators
3d62139
PR-URL: #14862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@BridgeAR@MylesBorins
doc: add BridgeAR to collaborators
d75e9b7
PR-URL: #14862
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Sep 20, 2017
Merged
@BridgeAR
BridgeAR deleted the add-me branch April 1, 2019 23:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@TrottTrottTrott approved these changes
@tniessentniessentniessen approved these changes
+2 more reviewers
@thefourtheyethefourtheyethefourtheye approved these changes
@vsemozhetbytvsemozhetbytvsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.notable-changePRs with changes that should be highlighted in changelogs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@BridgeAR@thefourtheye@jasnell@Trott@tniessen@vsemozhetbyt@MylesBorins@nodejs-github-bot