Skip to content

[v6.x backport] doc, lib, test: do not re-require needlessly - #14876

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:v6.x-stagingfrom
vsemozhetbyt:backport-14244-to-v6.x
Closed

[v6.x backport] doc, lib, test: do not re-require needlessly#14876
vsemozhetbyt wants to merge 1 commit into
nodejs:v6.x-stagingfrom
vsemozhetbyt:backport-14244-to-v6.x

Conversation

@vsemozhetbyt

@vsemozhetbytvsemozhetbyt commented Aug 16, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, lib, test

Backport of #14244

@nodejs-github-botnodejs-github-bot added process Issues and PRs related to the process subsystem. repl Issues and PRs related to the REPL subsystem. v6.x labels Aug 16, 2017
@vsemozhetbytvsemozhetbyt mentioned this pull request Aug 16, 2017
Closed
4 tasks
@vsemozhetbyt

vsemozhetbyt commented Aug 16, 2017

Copy link
Copy Markdown
ContributorAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/9699/

@vsemozhetbytvsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Aug 16, 2017
@BridgeAR

BridgeAR commented Aug 30, 2017

Copy link
Copy Markdown
Member

@nodejs/lts

@MylesBorins
MylesBorinsforce-pushed the v6.x-staging branch 2 times, most recently from aaf4e13 to 31f572cCompareSeptember 5, 2017 16:50
@vsemozhetbyt
doc, lib, test: do not re-require needlessly
be5b6c3
PR-URL: #14244
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
@vsemozhetbyt

vsemozhetbyt commented Sep 7, 2017

Copy link
Copy Markdown
ContributorAuthor

Rebased.

@MylesBorins

MylesBorins commented Sep 19, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

landed in 38ae5c4

@vsemozhetbyt
vsemozhetbyt deleted the backport-14244-to-v6.x branch September 19, 2017 13:22
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.processIssues and PRs related to the process subsystem.replIssues and PRs related to the REPL subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vsemozhetbyt@BridgeAR@MylesBorins@nodejs-github-bot