Skip to content

util: fix inspect array w. negative maxArrayLength - #14880

Closed
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-util-inspect
Closed

util: fix inspect array w. negative maxArrayLength#14880
BridgeAR wants to merge 1 commit into
nodejs:masterfrom
BridgeAR:fix-util-inspect

Conversation

@BridgeAR

@BridgeARBridgeAR commented Aug 17, 2017

Copy link
Copy Markdown
Member

This fixes a regression introduced in 95bbb68.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

util

@nodejs-github-botnodejs-github-bot added the util Issues and PRs related to the built-in util module. label Aug 17, 2017
@BridgeARBridgeAR mentioned this pull request Aug 17, 2017
Closed
4 tasks
@aqrln

aqrln commented Aug 17, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/9710/

BridgeAR added a commit to BridgeAR/node that referenced this pull request Aug 21, 2017
@BridgeAR
util: fix inspect array w. negative maxArrayLength
3a886ff
PR-URL: nodejs#14880
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeAR

BridgeAR commented Aug 21, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 3a886ff

MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@BridgeAR@MylesBorins
util: fix inspect array w. negative maxArrayLength
25833a5
PR-URL: #14880
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@BridgeAR@MylesBorins
util: fix inspect array w. negative maxArrayLength
de10c0f
PR-URL: #14880
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@BridgeARBridgeAR mentioned this pull request Sep 20, 2017
Closed
4 tasks
@MylesBorinsMylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. lts-watch-v6.x labels Sep 20, 2017
@MylesBorins

MylesBorins commented Sep 20, 2017

Copy link
Copy Markdown
Contributor

Needs to land with 95bbb68

@MylesBorinsMylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
+2 more reviewers
@TimothyGuTimothyGuTimothyGu approved these changes
@aqrlnaqrlnaqrln approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

utilIssues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@BridgeAR@aqrln@MylesBorins@jasnell@addaleax@TimothyGu@cjihrig@tniessen@nodejs-github-bot