Uh oh!
There was an error while loading. Please reload this page.
test: remove unsused arguments from function - #14931
Closed
0xparashar wants to merge 2 commits into
Closed
Conversation
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js
Contributor
Looks like there is a 'venv' directory that was incorrectly included in the commit and should be removed. |
0xparashar
commented
Aug 18, 2017
ContributorAuthor
removed that with the latest commit :) |
Trott
approved these changes
Aug 18, 2017
Trott
left a comment
Member
There was a problem hiding this comment.
Hello, @ankitiitb1069! Thanks for the PR! LGTM if CI run is successful.
Trott
commented
Aug 18, 2017
Member
hiroppy
approved these changes
Aug 18, 2017
refack
approved these changes
Aug 19, 2017
refack
commented
Aug 19, 2017
Contributor
Hello @ankitiitb1069 and welcome, GitHub is indicating this is your first contribution, so just in case you havn't already, it's recommended to take a look at the Anyway thank you for the contribution, and good luck. |
lpinca
approved these changes
Aug 19, 2017
cjihrig
approved these changes
Aug 20, 2017
jasnell
approved these changes
Aug 20, 2017
aqrln
approved these changes
Aug 22, 2017
aqrln
commented
Aug 22, 2017
Contributor
Hi @ankitiitb1069 and thanks for your contribution! I have started a fresh CI run since |
tniessen
commented
Aug 23, 2017
Member
Landed in 2a97eb6, thank you for your contribution! 🎉 |
tniessen pushed a commit
that referenced
this pull request
Aug 23, 2017
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: #14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Aug 25, 2017
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: nodejs/node#14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 28, 2017
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: nodejs/node#14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 10, 2017
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: #14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 12, 2017
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: #14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 20, 2017
Removed the unused arguments of functions defined in file test/parallel/test-http-parser.js. PR-URL: #14931 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed the unused arguments of functions defined in
file test/parallel/test-http-parser.js
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test