Skip to content

doc: rephrase wording of child_process.execSync() - #14953

Closed
ayazhafiz wants to merge 2 commits into
nodejs:masterfrom
ayazhafiz:master
Closed

doc: rephrase wording of child_process.execSync()#14953
ayazhafiz wants to merge 2 commits into
nodejs:masterfrom
ayazhafiz:master

Conversation

@ayazhafiz

@ayazhafizayazhafiz commented Aug 20, 2017

Copy link
Copy Markdown
Contributor

Rephrases the error thrown by child_process.execSync().

Fixes: #14944

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

@ayazhafiz
doc: rephrase wording of child_process.execSync()
416ea4f
Rephrases the error thrown by child_process.execSync().
Fixes: nodejs#14944
@nodejs-github-botnodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Aug 20, 2017
lpinca
lpinca reviewed Aug 20, 2017
View reviewed changes
Comment threaddoc/api/child_process.md Outdated
throw. The [`Error`][] object will contain the entire result from
[`child_process.spawnSync()`][]
throw an [`Error`][] that will include the full result of the underlying
[`spawnSync()`][].

@lpincalpincaAug 20, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would keep the child_process. prefix for consistency.

@daxlabdaxlabAug 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

considering this nit, rest all LGTM.

@ayazhafizayazhafizAug 20, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, should be fixed now!

@refackrefack self-assigned this Aug 20, 2017
jasnell pushed a commit that referenced this pull request Aug 23, 2017
@ayazhafiz@jasnell
doc: rephrase text of child_process.execSync()
e76b1ff
Rephrases the error thrown by child_process.execSync().
PR-URL: #14953Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

jasnell commented Aug 23, 2017

Copy link
Copy Markdown
Member

Landed in e76b1ff

@jasnelljasnell closed this Aug 23, 2017
@refackrefack removed their assignment Aug 23, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Aug 25, 2017
@ayazhafiz@addaleax
doc: rephrase text of child_process.execSync()
a2c7871
Rephrases the error thrown by child_process.execSync().
PR-URL: nodejs/node#14953Fixes: nodejs/node#14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Aug 28, 2017
@ayazhafiz@addaleax
doc: rephrase text of child_process.execSync()
d9a1740
Rephrases the error thrown by child_process.execSync().
PR-URL: nodejs/node#14953Fixes: nodejs/node#14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 10, 2017
@ayazhafiz@MylesBorins
doc: rephrase text of child_process.execSync()
bf7b79d
Rephrases the error thrown by child_process.execSync().
PR-URL: #14953Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Sep 10, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Sep 12, 2017
@ayazhafiz@MylesBorins
doc: rephrase text of child_process.execSync()
57c7eae
Rephrases the error thrown by child_process.execSync().
PR-URL: #14953Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 20, 2017
@ayazhafiz@MylesBorins
doc: rephrase text of child_process.execSync()
7546eef
Rephrases the error thrown by child_process.execSync().
PR-URL: #14953Fixes: #14944
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Sep 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+2 more reviewers
@daxlabdaxlabdaxlab approved these changes
@refackrefackrefack approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

child_processIssues and PRs related to the child_process subsystem.docIssues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@ayazhafiz@jasnell@refack@lpinca@cjihrig@daxlab@MylesBorins@nodejs-github-bot