Uh oh!
There was an error while loading. Please reload this page.
tools: fix linter error in html.js - #15063
Closed
targos wants to merge 1 commit into
Closed
Conversation
targos
commented
Aug 28, 2017
MemberAuthor
Error before the fix: |
3 tasks
targos
commented
Aug 28, 2017
MemberAuthor
Trott
approved these changes
Aug 28, 2017
Trott
left a comment
Member
There was a problem hiding this comment.
LGTM. No need to wait the full 48 hours on this, IMO.
hiroppy
approved these changes
Aug 28, 2017
cjihrig
approved these changes
Aug 28, 2017
targos
commented
Aug 28, 2017
MemberAuthor
Feel free to land it. I won't be able to before tomorrow. |
hiroppy pushed a commit
to hiroppy/node
that referenced
this pull request
Aug 28, 2017
PR-URL: nodejs#15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
hiroppy
commented
Aug 28, 2017
Member
landed in 7854562 |
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
ghost
pushed a commit
to ayojs/ayo
that referenced
this pull request
Aug 30, 2017
PR-URL: nodejs/node#15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
cjihrig pushed a commit
to cjihrig/node
that referenced
this pull request
Aug 31, 2017
PR-URL: nodejs#15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 10, 2017
PR-URL: #15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Sep 12, 2017
PR-URL: #15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
chris--young pushed a commit
to chris--young/node
that referenced
this pull request
Sep 29, 2017
PR-URL: nodejs#15063 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an error introduced in cacce30
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
tools