Uh oh!
There was an error while loading. Please reload this page.
http2: guard against destroy in socket timeout - #15106
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Aug 30, 2017
MemberAuthor
@AndrewBarba ... can you check to see if this resolves the issue you described in #14964 Sorry it's taken a bit to get this in! |
AndrewBarba
commented
Aug 30, 2017
No worries! Will test tonight/tomorrow |
mcollina
commented
Aug 31, 2017
Member
@jasnell I think you can test this by calling |
Guard against destroyed session in timeouts and goaway event. Improve timeout handling a bit. Fixes: nodejs#14964
jasnellforce-pushed
the
destroy-guard-in-timeout
branch
from
August 31, 2017 05:09
7792388 to
6930ac7Comparejasnell
commented
Sep 1, 2017
MemberAuthor
3 tasks
jasnell
commented
Sep 5, 2017
MemberAuthor
Landed in 09480a8 |
Merged
addaleax pushed a commit
to addaleax/node
that referenced
this pull request
Sep 13, 2017
Guard against destroyed session in timeouts and goaway event. Improve timeout handling a bit. PR-URL: nodejs#15106Fixes: nodejs#14964 Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is difficult to test reliably, but in certain
instances when timeout is emitted the session may already
be destroyed. Just guard against it.
Fixes: #14964
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2