net: persist net.Socket options before connect

[evanlucas]

Remembers net.Socket options called before connect and retroactively
applies them after the handle has been created.

This change makes the following function calls more user-friendly:

• setKeepAlive()
• setNoDelay()
• ref()
• unref()

Related: nodejs/node-v0.x-archive#7077 and
nodejs/node-v0.x-archive#8572

Repointing at master branch. See #880 for original PR

[brendanashworth]

Is there a reason why the ternary is here instead of just passing in enable? Is it the .bind perf?

[evanlucas]

Yes. That was @bnoordhuis recommendation.

[silverwind]

Regarding tests: I'm not sure if it's possibly to test TCP_NODELAY reliably on a localhost test. There's just no measureable latency difference in this situation. Are we fine with landing this with testing just for the call to setNoDelay happening?

[silverwind]

I'll LGTM this one.

Given the fact that both setNoDelay and setKeepAlive functionality are hard if not impossible to test on a localhost scenario, I'm fine with verifying that the call happened.

[evanlucas]

Ok. I'll land tomorrow provided @bnoordhuis is ok with it also

[evanlucas]

CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/689/

[bnoordhuis]

Maybe assert.equal(typeof connection.setKeepAlive, 'function')?

[bnoordhuis]

Can be made more rigorous if you increment/decrement a refCount variable and check that it has the expected value inside the method call (0 for ref, 1 for unref.)

[evanlucas]

Tests have been updated

[bnoordhuis]

Can you use assert.equal here?

[bnoordhuis]

@evanlucas Would it be possible for you to check that the tests conform to the linting rules in #1721? That would help avoid cleanup commits.

[evanlucas]

Alright, they pass linting now. Also added the requested changes

[bnoordhuis]

Sorry, didn't notice this before: can you explicitly close the open sockets here and the next test? Calling process.exit() in tests has made bugs go unnoticed the past so I'm kind of weary of it.

[bnoordhuis]

LGTM with a request.