Uh oh!
There was an error while loading. Please reload this page.
[v6.x] deps: backport 071b655 from V8 upstream - #15215
Closed
targos wants to merge 2 commits into
Closed
Conversation
Original commit message: [PATCH] [debugger] Scope iterator should not visit inner function literals. R=marja@chromium.org BUG=chromium:621361 Review-Url: https://codereview.chromium.org/2185913003 Cr-Commit-Position: refs/heads/master@{nodejs#38087} Fixes: nodejs#15075
cjihrig
approved these changes
Sep 6, 2017
jasnell
approved these changes
Sep 6, 2017
targos
commented
Sep 10, 2017
MemberAuthor
gibfahn
approved these changes
Sep 10, 2017
fhinkel
approved these changes
Sep 10, 2017
MylesBorins pushed a commit
that referenced
this pull request
Sep 19, 2017
Original commit message: [PATCH] [debugger] Scope iterator should not visit inner function literals. R=marja@chromium.org BUG=chromium:621361 Review-Url: https://codereview.chromium.org/2185913003 Cr-Commit-Position: refs/heads/master@{#38087} Fixes: #15075 PR-URL: #15215 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins
commented
Sep 19, 2017
Contributor
landed in 921876d |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original commit message:
Fixes: #15075
/cc @nodejs/v8 @hashseed
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
V8