Uh oh!
There was an error while loading. Please reload this page.
Fixed a typo in LICENSE - #15261
Conversation
Line 234: "Copyrighy" instead of "Copyright".
richardlau
commented
Sep 8, 2017
Thanks for submitting. This part of the LICENSE is generated from |
Thanks for the pointer. I can PR |
Trott
commented
Sep 8, 2017
Hi @MKRhere! Welcome and thanks for this! The typo is in a dependency and so that file will also be overwritten the next time we update from the upstream source. The change request should go to the ICU project. You can see the typo in their source tree at http://source.icu-project.org/repos/icu/trunk/icu4c/LICENSE. Their guide on how to contribute to their project is at http://site.icu-project.org/processes/contribute. |
MKRhere
commented
Sep 9, 2017
Added trac issue at ICU. Closing this issue. |
srl295
commented
Sep 13, 2017
@MKRhere ok sorry, i saw this go by but didn't see that it was in ICU. No, please do not change deps/small-icu, it is generated as mentioned. The file is actually not sourced from ICU but yet another embedded source. ICU will be making patch though, so in a future ICU this will be fixed. Thanks. |
Line 234: "Copyrighy" instead of "Copyright".