Skip to content

errors: fix ERR_MODULE_RESOLUTION_LEGACY message - #15290

Closed
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:legacy-fix-space
Closed

errors: fix ERR_MODULE_RESOLUTION_LEGACY message#15290
tniessen wants to merge 2 commits into
nodejs:masterfrom
tniessen:legacy-fix-space

Conversation

@tniessen

@tniessentniessen commented Sep 9, 2017•
edited by bmeck
Loading

Copy link
Copy Markdown
Member

Refs: #14369

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

errors

@tniessentniessen added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Sep 9, 2017
@tniessen
tniessen requested a review from bmeckSeptember 9, 2017 09:52
@nodejs-github-botnodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Sep 9, 2017
Trott
Trott reviewed Sep 9, 2017
View reviewed changes
Comment threadlib/internal/errors.js Outdated
E('ERR_MISSING_MODULE', 'Cannot find module %s');
E('ERR_MODULE_RESOLUTION_LEGACY', '%s not found by import in %s.' +
'Legacy behavior in require would have found it at %s');
'Legacy behavior in require would have found it at %s');

@TrottTrottSep 9, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question/nit: require -> require()?

@tniessentniessenSep 10, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with that change, @bmeck?

@bmeckbmeckSep 10, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, seems fine

@tniessen

tniessen commented Sep 12, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 6ccb9fe.

tniessen added a commit that referenced this pull request Sep 12, 2017
@tniessen
errors: fix ERR_MODULE_RESOLUTION_LEGACY message
6ccb9fe
PR-URL: #15290
Refs: #14369
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to addaleax/node that referenced this pull request Sep 13, 2017
@tniessen@addaleax
errors: fix ERR_MODULE_RESOLUTION_LEGACY message
53e31c7
PR-URL: nodejs#15290
Refs: nodejs#14369
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnell

jasnell commented Sep 20, 2017

Copy link
Copy Markdown
Member

This will need to be backported for v8.x

jasnell pushed a commit that referenced this pull request Sep 20, 2017
@tniessen@jasnell
errors: fix ERR_MODULE_RESOLUTION_LEGACY message
b58a2aa
PR-URL: #15290
Refs: #14369
Reviewed-By: Bradley Farias <bradley.meck@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@jasnelljasnell mentioned this pull request Sep 20, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott left review comments
@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@bmeckbmeckbmeck approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

errorsIssues and PRs related to JavaScript errors originated in Node.js core.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@tniessen@jasnell@bmeck@Trott@lpinca@cjihrig@MylesBorins@nodejs-github-bot