Skip to content

test: move test-benchmark-buffer to sequential - #15373

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mv-buffer-to-seq
Closed

test: move test-benchmark-buffer to sequential#15373
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:mv-buffer-to-seq

Conversation

@Trott

@TrottTrott commented Sep 12, 2017

Copy link
Copy Markdown
Member

test-benchmark-buffer has been observed to timeout on CI on SmartOS.
Move the test to sequential so it is not competing with other tests
for resources.

Fixes: #15372

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test benchmark buffer

@Trott
test: move test-benchmark-buffer to sequential
5d698bc
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.
Fixes: nodejs#15372
@TrottTrott added the test Issues and PRs related to the tests. label Sep 12, 2017
@TrottTrott mentioned this pull request Sep 12, 2017
Closed
@mscdexmscdex added benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. labels Sep 12, 2017
@refackrefack mentioned this pull request Sep 12, 2017
Closed
3 tasks
@Trott

Trott commented Sep 12, 2017

Copy link
Copy Markdown
MemberAuthor

Stress test (started by @mscdex) to see if it's not a problem with the test itself: https://ci.nodejs.org/job/node-stress-single-test/1409/

If that stress test comes back green, that would suggest that moving the test to sequential is a solution (or at least an effective workaround).

If that stress test comes back red, that would suggest that moving the test to sequential would not eliminate the test flakiness (although it would likely reduce test flakiness).

@refack

refack commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Cross-ref: https://ci.nodejs.org/job/node-stress-single-test/1409/ was stopped after 19h (OK: 1934 NOT OK: 0). I'd say it's stable on it's own.

@jasnell

jasnell commented Sep 14, 2017

Copy link
Copy Markdown
Member

This needs a rebase.

@jasnell

jasnell commented Sep 14, 2017

Copy link
Copy Markdown
Member

..nvm .. I rebased on landing...

jasnell pushed a commit that referenced this pull request Sep 14, 2017
@Trott@jasnell
test: move test-benchmark-buffer to sequential
082c434
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.
PR-URL: #15373Fixes: #15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell

jasnell commented Sep 14, 2017

Copy link
Copy Markdown
Member

Landed in 082c434

@jasnelljasnell closed this Sep 14, 2017
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 17, 2017
@Trott@addaleax
test: move test-benchmark-buffer to sequential
d2722fb
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.
PR-URL: nodejs/node#15373Fixes: nodejs/node#15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Sep 20, 2017
@Trott@jasnell
test: move test-benchmark-buffer to sequential
4d26c68
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.
PR-URL: #15373Fixes: #15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnelljasnell mentioned this pull request Sep 20, 2017
Merged
Qard pushed a commit to Qard/ayo that referenced this pull request Sep 21, 2017
@TrottStephen Belanger
test: move test-benchmark-buffer to sequential
9f8e9b1
`test-benchmark-buffer` has been observed to timeout on CI on SmartOS.
Move the test to `sequential` so it is not competing with other tests
for resources.
PR-URL: nodejs/node#15373Fixes: nodejs/node#15372
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Trott deleted the mv-buffer-to-seq branch January 13, 2022 22:46
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes
@BridgeARBridgeARBridgeAR approved these changes
+3 more reviewers
@refackrefackrefack approved these changes
@evanlucasevanlucasevanlucas approved these changes
@hiroppyhiroppyhiroppy approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

benchmarkIssues and PRs related to the benchmark subsystem.bufferIssues and PRs related to the buffer subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky parallel/test-benchmark-buffer.js on SmartOS

9 participants

@Trott@refack@jasnell@evanlucas@cjihrig@hiroppy@BridgeAR@mscdex@MylesBorins