Skip to content

test: defer abort with setTimeout - #15520

Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-flaky-http-test
Closed

test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom
mcollina:fix-flaky-http-test

Conversation

@mcollina

@mcollinamcollina commented Sep 21, 2017

Copy link
Copy Markdown
Member

Ref: #15404
Fixes: #15505

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, http

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to Node.js core tests and test infrastructure. label Sep 21, 2017
@mcollina

mcollina commented Sep 21, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10175/

@mscdexmscdex added the http Issues and PRs related to the http subsystem. label Sep 21, 2017
@mcollina

mcollina commented Sep 21, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10176/

@mcollina

mcollina commented Sep 21, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10177/

lpinca
lpinca reviewed Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@lpincalpincaSep 21, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?
This would remove the setTimeout dependency.

@mcollina

mcollina commented Sep 21, 2017

Copy link
Copy Markdown
MemberAuthor

@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(

@lpinca

lpinca commented Sep 21, 2017

Copy link
Copy Markdown
Member

Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.

@cjihrig

cjihrig commented Sep 21, 2017

Copy link
Copy Markdown
Contributor

While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?

@mcollina

mcollina commented Sep 21, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10181/

@mcollina

mcollina commented Sep 21, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10182/

@mcollina

mcollina commented Sep 22, 2017

Copy link
Copy Markdown
MemberAuthor

ci: https://ci.nodejs.org/job/node-test-pull-request/10193/

@mcollina

mcollina commented Sep 22, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10197/

@mcollina

mcollina commented Sep 22, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10199/

@mcollina

mcollina commented Sep 22, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10202/

@BridgeAR

BridgeAR commented Sep 25, 2017

Copy link
Copy Markdown
Member

@mcollina we could also mark the test as being flaky on centos?

@mcollina

mcollina commented Sep 25, 2017

Copy link
Copy Markdown
MemberAuthor

CI https://ci.nodejs.org/job/node-test-pull-request/10248/

BridgeAR
BridgeAR reviewed Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@BridgeARBridgeARSep 25, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?

@mcollinamcollinaSep 25, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.

I'll see if I can get another solution as well.

I'll add another check that verifies that at least one of them is called.

@mcollina

mcollina commented Sep 25, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10253/

@mcollina

mcollina commented Sep 25, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10255/

@mcollina

mcollina commented Sep 26, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10273/

This should be green, and it can land as it finshes.

@jasnell@lpinca@cjihrig can you review it again so we can land?

lpinca
lpinca reviewed Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@lpincalpincaSep 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '

lpinca
lpinca reviewed Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@lpincalpincaSep 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.

lpinca
lpinca reviewed Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@lpincalpincaSep 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?

@mcollina

mcollina commented Sep 26, 2017

Copy link
Copy Markdown
MemberAuthor

@lpinca thanks, updated!

CI: https://ci.nodejs.org/job/node-test-pull-request/10274/

lpinca
lpinca approved these changes Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@lpincalpincaSep 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.

Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@lpincalpincaSep 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.

cjihrig
cjihrig reviewed Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@cjihrigcjihrigSep 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.

Comment threadtest/parallel/test-http-writable-true-after-close.js Outdated

@cjihrigcjihrigSep 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().

@lpincalpincaSep 26, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.

@cjihrigcjihrigSep 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.

@lpincalpincaSep 26, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.

@cjihrigcjihrigSep 26, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:

Is this called more than once on any platforms?

We shouldn't remove the listeners unless we really need to.

@mcollina

mcollina commented Sep 27, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10286/

@mcollina

mcollina commented Sep 27, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10287/

@cjihrig@lpinca updated

@lpinca

lpinca commented Sep 27, 2017

Copy link
Copy Markdown
Member

Still LGTM.

@mcollina

mcollina commented Sep 27, 2017

Copy link
Copy Markdown
MemberAuthor

Landed as 1fe9b53

@mcollina
mcollina deleted the fix-flaky-http-test branch September 27, 2017 13:09
mcollina added a commit that referenced this pull request Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit to MylesBorins/node that referenced this pull request Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott mentioned this pull request Sep 30, 2017
Closed
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott mentioned this pull request Sep 30, 2017
Closed
@MylesBorinsMylesBorins mentioned this pull request Oct 3, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot mentioned this pull request Feb 12, 2022
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees

No one assigned

Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
test: defer abort with setTimeout by mcollina · Pull Request #15520 · nodejs/node · GitHub
Skip to content
test: defer abort with setTimeout - #15520
Closed
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Closed
test: defer abort with setTimeout#15520
mcollina wants to merge 1 commit into
nodejs:masterfrom 
mcollina:fix-flaky-http-test
Conversation
@mcollina
@mcollinamcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Ref: #15404
Fixes: #15505
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  •  commit message follows commit guidelines
Affected core subsystem(s)
test, http
@nodejs-github-botnodejs-github-bot
added
the 
test
Issues and PRs related to Node.js core tests and test infrastructure.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10175/
@mscdexmscdex
added
the 
http
Issues and PRs related to the http subsystem.
label
Sep 21, 2017
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10176/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10177/
lpinca
lpinca
reviewed
Sep 21, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 21, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it safe to call external.abort() and internalRes.end('Hello World\n'); here or does this invalidate the test?

This would remove the setTimeout dependency.
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca the problem is that this test keeps failing only on Centos and I do not know why :(
@lpinca
lpinca
commented
Sep 21, 2017

Copy link


Copy Markdown

Member
Yes that's weird, it looks like res.on('close', ...) is not emitted but I don't know why.
@cjihrig
cjihrig
commented
Sep 21, 2017

Copy link


Copy Markdown

Contributor
While you're here, could you move the stuff from // Proxy server until the end of the file into the internal server's listen() callback?
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10181/
@mcollina
mcollina
commented
Sep 21, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10182/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
ci: https://ci.nodejs.org/job/node-test-pull-request/10193/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10197/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10199/
@mcollina
mcollina
commented
Sep 22, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10202/
@BridgeAR
BridgeAR
commented
Sep 25, 2017

Copy link


Copy Markdown

Member
@mcollina we could also mark the test as being flaky on centos?
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI https://ci.nodejs.org/job/node-test-pull-request/10248/
BridgeAR
BridgeAR
reviewed
Sep 25, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@BridgeARBridgeARSep 25, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will test less than before, since the mustCall is not in place anymore. It might be worth to check that either finish or close will be called at least once? And I am somewhat surprised that our events are platform dependent. Would you be so kind and add a comment why that is the case?
@mcollinamcollinaSep 25, 2017

Copy link


Copy Markdown

MemberAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea on why it's the case, that's the major problem of this PR.
I'll see if I can get another solution as well.
I'll add another check that verifies that at least one of them is called.
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10253/
@mcollina
mcollina
commented
Sep 25, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10255/
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10273/
This should be green, and it can land as it finshes.
@jasnell@lpinca@cjihrig can you review it again so we can land?
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing '
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd point out that this only happens on CentOS 5.
lpinca
lpinca
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess these are only for debugging. Do we want to keep them?
@mcollina
mcollina
commented
Sep 26, 2017

Copy link


Copy Markdown

MemberAuthor
@lpinca thanks, updated!
CI: https://ci.nodejs.org/job/node-test-pull-request/10274/
lpinca
lpinca
approved these changes
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing semicolon.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto.
cjihrig
cjihrig
reviewed
Sep 26, 2017
View reviewed changes
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't needed after all.
Comment threadtest/parallel/test-http-writable-true-after-close.js
Outdated

@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this called more than once on any platforms? Removing the listeners kind of defeats the purpose of wrapping it in common.mustCall().
@lpincalpincaSep 26, 2017

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the point is to ensure that the listener is actually called.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but common.mustCall() also enforces the number of times the function is called. Removing the listeners means we lose that checking.
@lpincalpincaSep 26, 2017•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think either 'close' or 'finish' should be emitted so it doesn't matter as long as at least one is emitted.
@cjihrigcjihrigSep 26, 2017

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I asked:
Is this called more than once on any platforms?
We shouldn't remove the listeners unless we really need to.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10286/
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
CI: https://ci.nodejs.org/job/node-test-pull-request/10287/
@cjihrig@lpinca updated
@lpinca
lpinca
commented
Sep 27, 2017

Copy link


Copy Markdown

Member
Still LGTM.
@mcollina
mcollina
commented
Sep 27, 2017

Copy link


Copy Markdown

MemberAuthor
Landed as 1fe9b53
@mcollina
mcollina
deleted the

fix-flaky-http-test

branch
September 27, 2017 13:09
mcollina added a commit
that referenced
this pull request
Sep 27, 2017
@mcollina
test: fix http-writable-true-after-close flakyness
1fe9b53
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
to MylesBorins/node
that referenced
this pull request
Sep 28, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
067c5e4
Ref: nodejs#15404Fixes: nodejs#15505
PR-URL: nodejs#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Sep 29, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
f2fde76
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Sep 30, 2017
@mcollina@addaleax
test: fix http-writable-true-after-close flakyness
14c9585
Ref: nodejs/node#15404Fixes: nodejs/node#15505
PR-URL: nodejs/node#15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@TrottTrott
mentioned this pull request
Sep 30, 2017

Closed

@MylesBorinsMylesBorins
mentioned this pull request
Oct 3, 2017
 Merged

MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
@mcollina@MylesBorins
test: fix http-writable-true-after-close flakyness
0aea258
Ref: #15404Fixes: #15505
PR-URL: #15520
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@snyk-botsnyk-bot
mentioned this pull request
Feb 12, 2022
 Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@BridgeARBridgeARBridgeAR left review comments
@jasnelljasnelljasnell approved these changes
@cjihrigcjihrigcjihrig approved these changes

Assignees


No one assigned


Labels

httpIssues and PRs related to the http subsystem.testIssues and PRs related to Node.js core tests and test infrastructure.

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

8 participants

@mcollina@lpinca@cjihrig@BridgeAR@jasnell@mscdex@MylesBorins@nodejs-github-bot