Skip to content

fs: validate fd on fs.write - #1553

Closed
julianduque wants to merge 1 commit into
nodejs:masterfrom
julianduque:fix-fs-write
Closed

fs: validate fd on fs.write#1553
julianduque wants to merge 1 commit into
nodejs:masterfrom
julianduque:fix-fs-write

Conversation

@julianduque

Copy link
Copy Markdown
Contributor

This PR fixes#1550

@mscdexmscdex added the fs Issues and PRs related to the fs subsystem / file system. label Apr 28, 2015
Comment threadsrc/node_file.cc Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this check still required?

@julianduque

Copy link
Copy Markdown
ContributorAuthor

@cjihrig fixed PR with your suggestions

@cjihrig

Copy link
Copy Markdown
Contributor

LGTM

julianduque added a commit that referenced this pull request Apr 28, 2015
PR-URL: #1553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@julianduque

Copy link
Copy Markdown
ContributorAuthor

Landed in f9c681c

@julianduque
julianduque deleted the fix-fs-write branch April 28, 2015 22:47
@rvaggrvagg mentioned this pull request Apr 29, 2015
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Apr 29, 2015
PR-URL: nodejs#1553
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request May 14, 2015
PR-URL: nodejs#1553
PORT-PR-URL: nodejs#1560
PORT-FROM: v2.x / f9c681c
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Fishrock123Fishrock123 mentioned this pull request May 14, 2015
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fsIssues and PRs related to the fs subsystem / file system.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fs.write crashes on non-integer fd

3 participants

@julianduque@cjihrig@mscdex