Uh oh!
There was an error while loading. Please reload this page.
test: extend timeouts for ARMv6 - #1554
Conversation
silverwind
commented
Apr 29, 2015
The x6 factor was already very generous, it surprises me a bit that you still have issues. I suspect your SD must be of a very slow kind or something. LGTM, if it helps. |
rvagg
commented
Apr 29, 2015
could be .. one of the Pi's particularly has an older SD card. An alternative to raising it to 7 is going through the individual tests that have been failing and extending them rather than doing the whole lot. |
jbergstroem
commented
Apr 29, 2015
I went through ccache statistics on all the PI's. They have a very high hitrate – so getting faster storage would probably be the best solution :/ |
silverwind
commented
Apr 29, 2015
If I remember correctly, the RPi doesn't have a dedicated storage controller, so all SD access is done on the CPU, which puts a hard limit on the transfer rate you can get. I'm fine with x7 myself. |
Based on tests running on original Raspberry Pi PR-URL: #1554 Reviewed-By: Roman Reiss <me@silverwind.io>
rvagg
commented
Apr 29, 2015
Based on tests running on original Raspberry Pi PR-URL: nodejs#1554 Reviewed-By: Roman Reiss <me@silverwind.io>
Based on tests running on original Raspberry Pi PR-URL: nodejs#1554 PORT-PR-URL: nodejs#1560 PORT-FROM: v2.x / f9b226c Reviewed-By: Roman Reiss <me@silverwind.io>
Background: I suspect the ARMv6 timeouts introduced by @silverwind were based on a Pi B+ or similar or perhaps an overclocked Pi. The CI cluster has 2 x original Pi's and 1 x Pi B+ and the tests don't consistently pass on the older Pi's.
This configuration gives me all passes but I'd appreciate review by @silverwind and anyone else familiar with the specific tests I've adjusted: test-child-process-fork-net2.js, test-debug-signal-cluster.js, test-next-tick-error-spin.js