Skip to content

test: verify sending net.Server via cluster - #15559

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:cluster-test
Closed

test: verify sending net.Server via cluster#15559
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:cluster-test

Conversation

@cjihrig

Copy link
Copy Markdown
Contributor

This test verifies that a net.Server instance can be sent via cluster workers.

This adds a regression test for #15556.

Fixes: #15556
Refs: #14221

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

This test verifies that a net.Server instance can be sent
via cluster workers.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Sep 22, 2017
@mscdexmscdex added the net Issues and PRs related to the net subsystem. label Sep 22, 2017
@lpinca

Copy link
Copy Markdown
Member

@lpinca

Copy link
Copy Markdown
Member

There are some failures on Windows:

not ok 64 parallel/test-cluster-send-net-server
---
duration_ms: 0.295
severity: fail
stack: |-
net.js:1280
err = handle.bind6('::', port);
^
TypeError: handle.bind6 is not a function
at Object.createServerHandle [as _createServerHandle] (net.js:1280:20)
at new SharedHandle (internal/cluster/shared_handle.js:18:16)
at queryServer (internal/cluster/master.js:288:29)
at Worker.onmessage (internal/cluster/master.js:244:5)
at ChildProcess.onInternalMessage (internal/cluster/utils.js:42:8)
at emitTwo (events.js:130:20)
at ChildProcess.emit (events.js:213:7)
at emit (internal/child_process.js:791:12)
at _combinedTickCallback (internal/process/next_tick.js:141:11)
at process._tickCallback (internal/process/next_tick.js:180:9)

@BridgeAR

Copy link
Copy Markdown
Member

Ping @cjihrig

@cjihrig

Copy link
Copy Markdown
ContributorAuthor

Closing. If anyone wants to pick this up and finish the Windows piece, feel free.

@cjihrigcjihrig closed this Oct 24, 2017
@cjihrig
cjihrig deleted the cluster-test branch October 24, 2017 01:31
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

netIssues and PRs related to the net subsystem.testIssues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@cjihrig@lpinca@BridgeAR@jasnell@mscdex@nodejs-github-bot