Uh oh!
There was an error while loading. Please reload this page.
inspector: migrate to internal/errors - #15619
Closed
jasnell wants to merge 3 commits into
Closed
Conversation
jasnell
commented
Sep 26, 2017
MemberAuthor
Ping @nodejs/tsc |
jasnell
commented
Sep 26, 2017
MemberAuthor
lpinca
approved these changes
Sep 26, 2017
Member
There was a problem hiding this comment.
Other errors mainly use 'object' (lower cased).
Member
Do we not have any tests for the inspector error cases? |
jasnell
commented
Sep 26, 2017
MemberAuthor
@BridgeAR ... none that were affected... which is a bit scary. |
BridgeAR
commented
Sep 28, 2017
Member
@jasnell would you be so kind and add some for those? I think it would be a shame not to use the opportunity otherwise. |
jasnell
commented
Sep 28, 2017
MemberAuthor
Sure :-) gimme a couple of days tho. |
80 tasks
jasnellforce-pushed
the
inspector-internal-errors
branch
from
October 2, 2017 18:43
6aac4f2 to
81cf213Comparejasnell
commented
Oct 2, 2017
MemberAuthor
Test added! |
jasnellforce-pushed
the
inspector-internal-errors
branch
2 times, most recently
from
October 2, 2017 19:12
6c1c982 to
5bf3c97Comparejasnellforce-pushed
the
inspector-internal-errors
branch
from
October 13, 2017 21:07
5bf3c97 to
3498510Comparejasnell
commented
Oct 13, 2017
MemberAuthor
Ping @nodejs/tsc ... review please? |
jasnell
commented
Oct 13, 2017
MemberAuthor
joyeecheung
approved these changes
Oct 14, 2017
| E('ERR_HTTP_TRAILER_INVALID', | ||
| 'Trailers are invalid with this transfer encoding'); | ||
| E('ERR_INDEX_OUT_OF_RANGE', 'Index out of range'); | ||
| E('ERR_INSPECTOR_ALREADY_CONNECTED', 'Already connected'); |
Member
There was a problem hiding this comment.
Nit: The inspector is already connected?
jasnell added a commit
that referenced
this pull request
Oct 16, 2017
PR-URL: #15619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jasnell
commented
Oct 16, 2017
MemberAuthor
Landed in 4cf56ad |
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 18, 2017
PR-URL: nodejs/node#15619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
migrate to internal/errors
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
inspector,errors