Uh oh!
There was an error while loading. Please reload this page.
stream: fix disparity between buffer and the count - #15661
Closed
jlvivero wants to merge 2 commits into
Closed
Conversation
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js Fixes: nodejs#6758
BridgeAR
approved these changes
Sep 28, 2017
BridgeAR
left a comment
Member
There was a problem hiding this comment.
LGTM. It would be nice to address the nit - otherwise this could be done while landing.
| 'use strict'; | ||
| const common = require('../common'); | ||
| const Stream = require('stream'); | ||
| //this test ensures that the _writeableState.bufferedRequestCount and |
Member
There was a problem hiding this comment.
Nit - would you be so kind upper case the first letter and also add a whitespace after //?
ContributorAuthor
There was a problem hiding this comment.
Sure no problem, would there be any other style changes you'd think might be appropriate? If not I'll just commit with that one change and squash if required/requested.
Member
There was a problem hiding this comment.
In the comment below, please also add a whitespace on each line after //. Besides that everything is LGTM.
jasnell
commented
Sep 29, 2017
Member
ping @nodejs/streams |
cjihrig
approved these changes
Sep 30, 2017
jasnell
approved these changes
Oct 1, 2017
BridgeAR
commented
Oct 1, 2017
Member
BridgeAR
commented
Oct 2, 2017
Member
Landed in 34dbc9e |
BridgeAR pushed a commit
that referenced
this pull request
Oct 2, 2017
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: #15661Fixes: #6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: #15661Fixes: #6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Oct 3, 2017
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: #15661Fixes: #6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 4, 2017
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: nodejs/node#15661Fixes: nodejs/node#6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 11, 2017
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: #15661Fixes: #6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Oct 17, 2017
Contributor
This lands cleanly on v6.x, but I think it might make sense to wait a bit longer to see if it causes any issues due to how fragile streams could be. Please lmk if you think it should make it into the next release |
MylesBorins
commented
Dec 19, 2017
Contributor
ping @mcollina and @nodejs/streams should this be included in the next 6.x? |
mcollina
commented
Dec 20, 2017
Member
@MylesBorins yeah, go ahead and backport. It's safe. |
MylesBorins pushed a commit
that referenced
this pull request
Dec 20, 2017
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: #15661Fixes: #6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Jan 2, 2018
This changes the disparity of bufferedRequestCount and the actual buffer on file _stream_writable.js PR-URL: #15661Fixes: #6758 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changes the disparity of bufferedRequestCount and the actual buffer
on file _stream_writable.js
Fixes: #6758
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
Stream Writable
Note: I introduced the test in the sequential subfolder because I couldn't think of another way to test that part of the code without using a timeout (like in the example of the issue thread).