aix, test: prolong debugged child process by jBarz · Pull Request #15774 · nodejs/node

jBarz · 2017-10-04T20:33:43Z

On AIX, there is a possibility that the child process is done before the parent debugger can connect to it. So prolong the child process by factor of 2.

Fixes: #14897

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

gibfahn · 2017-10-10T21:03:01Z

Needs a stress test

refack · 2017-10-10T21:28:27Z

https://ci.nodejs.org/job/node-stress-single-test/1446/nodes=aix61-ppc64/

gibfahn · 2017-10-10T22:25:13Z

Still looking a bit flaky: 1237 OK: 1228 NOT OK: 9 TOTAL: 9999

Is there a way for the child process to pause until the debugger is attached?

refack · 2017-10-10T22:56:02Z

Is there a way for the child process to pause until the debugger is attached?

Maybe replace --inspect=0 with --inspect-brk=0 (there's already a Runtime.runIfWaitingForDebugger that will "continue" execution)

jBarz · 2017-10-13T02:18:18Z

Can we do the stress test again?

gibfahn · 2017-10-13T07:48:42Z

@jBarz not till nodejs/build#775 (comment) is resolved.

gibfahn · 2017-10-19T13:51:33Z

@jBarz if you rebase I'll stress test.

jBarz · 2017-10-19T13:56:10Z

Thanks @gibfahn , done!

gibfahn · 2017-10-19T19:02:27Z

Stress: https://ci.nodejs.org/job/node-stress-single-test/1457

gibfahn · 2017-10-20T17:57:52Z

CI: https://ci.nodejs.org/job/node-test-commit/13334/

mhdawson

LGTM the change but I think we also need to revert the AIX part of 7027191 so that it is no longer marked as flaky for AIX.

Pause child on startup using inspect-brk=0 until the parent debugger is ready.

jBarz · 2017-10-24T20:01:09Z

I made another change which no longer marks this test as flaky for aix and windows.

refack

Should stress test, but code LGTM

mhdawson · 2017-11-02T15:06:08Z

I think earlier stress test showed it was good.

New CI since it has been 2 weeks: https://ci.nodejs.org/job/node-test-pull-request/11152/

mhdawson · 2017-11-02T17:30:32Z

arm failures were infra issues not related to this PR.

mhdawson · 2017-11-02T18:28:34Z

Windows failure was #16688

so net is that CI is good with respect to this change.

Pause child on startup using inspect-brk=0 until the parent debugger is ready. PR-URL: #15774Fixes: #14897 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

mhdawson · 2017-11-02T18:41:06Z

Landed as f1f0eb2

Pause child on startup using inspect-brk=0 until the parent debugger is ready. PR-URL: nodejs#15774Fixes: nodejs#14897 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

Pause child on startup using inspect-brk=0 until the parent debugger is ready. PR-URL: #15774Fixes: #14897 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol test Issues and PRs related to the tests. labels Oct 4, 2017

jBarz force-pushed the master.aix branch from b4aaf06 to e1d7fcbCompare October 4, 2017 20:35

jBarz mentioned this pull request Oct 10, 2017
Intermittent failures in inspector/test-stop-profile-after-done - AIX #14897
Closed

gibfahn approved these changes Oct 10, 2017
View reviewed changes

refack approved these changes Oct 10, 2017
View reviewed changes

jBarz force-pushed the master.aix branch from e1d7fcb to 886cc1dCompare October 13, 2017 02:17

jBarz force-pushed the master.aix branch from 886cc1d to 9f2039cCompare October 19, 2017 13:55

gireeshpunathil approved these changes Oct 20, 2017
View reviewed changes

jasnell approved these changes Oct 20, 2017
View reviewed changes

mhdawson approved these changes Oct 24, 2017
View reviewed changes

jBarz force-pushed the master.aix branch from 9f2039c to a780499Compare October 24, 2017 19:59

aix, test: pause child until parent is ready
34d5b9e
Pause child on startup using inspect-brk=0 until the parent debugger is ready.

jBarz force-pushed the master.aix branch from a780499 to 34d5b9eCompare October 24, 2017 20:00

refack approved these changes Oct 24, 2017
View reviewed changes

mhdawson closed this Nov 2, 2017

jBarz deleted the master.aix branch November 3, 2017 00:07

cjihrig mentioned this pull request Nov 6, 2017
v9.1.0 proposal #16851
Merged

jackhorton mentioned this pull request Nov 8, 2017
test: inspector test hangs nodejs/node-chakracore#423
Closed

gibfahn added the land-on-v8.x label Nov 14, 2017

MylesBorins added the dont-land-on-v6.x label Nov 14, 2017

gibfahn mentioned this pull request Nov 21, 2017
v8.9.2 proposal #17204
Merged

Uh oh!

Uh oh!

Conversation

jBarz commented Oct 4, 2017• edited by gibfahn Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

gibfahn commented Oct 10, 2017

Uh oh!

refack commented Oct 10, 2017

Uh oh!

gibfahn commented Oct 10, 2017

Uh oh!

refack commented Oct 10, 2017

Uh oh!

jBarz commented Oct 13, 2017

Uh oh!

gibfahn commented Oct 13, 2017

Uh oh!

gibfahn commented Oct 19, 2017

Uh oh!

jBarz commented Oct 19, 2017

Uh oh!

gibfahn commented Oct 19, 2017

Uh oh!

gibfahn commented Oct 20, 2017

Uh oh!

mhdawson left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jBarz commented Oct 24, 2017

Uh oh!

refack left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mhdawson commented Nov 2, 2017

Uh oh!

mhdawson commented Nov 2, 2017

Uh oh!

mhdawson commented Nov 2, 2017

Uh oh!

mhdawson commented Nov 2, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jBarz commented Oct 4, 2017•
edited by gibfahn
Loading

mhdawson left a comment •
edited
Loading

refack left a comment •
edited
Loading