Skip to content

test: replace common.fixturesDir with fixtures. - #15802

Closed
codeviking wants to merge 1 commit into
nodejs:masterfrom
codeviking:common-fixtures
Closed

test: replace common.fixturesDir with fixtures.#15802
codeviking wants to merge 1 commit into
nodejs:masterfrom
codeviking:common-fixtures

Conversation

@codeviking

@codevikingcodeviking commented Oct 6, 2017

Copy link
Copy Markdown

Replaces the use of common.fixturesDir with the generic fixtures
mechanism.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
richardlau
richardlau reviewed Oct 6, 2017
View reviewed changes
Comment threadtest/parallel/test-fs-write-stream-encoding.js Outdated

@richardlaurichardlauOct 6, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could alternatively be fixtures.path('x.txt').

@codevikingcodevikingOct 6, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah! Great. That seems better. I'll tweak that shortly.

Sam Skjonsberg
test: replace common.fixturesDir with fixtures.
65aabc5
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
@codeviking

codeviking commented Oct 6, 2017

Copy link
Copy Markdown
Author

@richardlau I updated to use fixtures.path -- thanks for the tip!

@mscdexmscdex added the fs Issues and PRs related to the fs subsystem / file system. label Oct 6, 2017
@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@Trott

Trott commented Oct 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10466/

Trott pushed a commit to Trott/io.js that referenced this pull request Oct 8, 2017
Sam Skjonsberg@Trott
test: replace common.fixturesDir with fixtures.
eb08e3e
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: nodejs#15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott

Trott commented Oct 8, 2017

Copy link
Copy Markdown
Member

Landed in eb08e3e.
Thanks for the contribution! 🎉

@TrottTrott closed this Oct 8, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
Sam Skjonsberg@MylesBorins
test: replace common.fixturesDir with fixtures.
73a41cf
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
Sam Skjonsberg@addaleax
test: replace common.fixturesDir with fixtures.
800c542
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: nodejs/node#15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
Sam Skjonsberg@MylesBorins
test: replace common.fixturesDir with fixtures.
5b931d7
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Sam Skjonsberg@MylesBorins
test: replace common.fixturesDir with fixtures.
cbf0d62
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Sam Skjonsberg@MylesBorins
test: replace common.fixturesDir with fixtures.
4005ed6
Replaces the use of `common.fixturesDir` with the generic `fixtures`
mechanism.
PR-URL: #15802
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrottTrottTrott approved these changes
@cjihrigcjihrigcjihrig approved these changes
@richardlaurichardlaurichardlau approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.fsIssues and PRs related to the fs subsystem / file system.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@codeviking@Trott@cjihrig@richardlau@gireeshpunathil@mscdex@MylesBorins@nodejs-github-bot