Skip to content

test: replace string concatenation in test file - #15915

Closed
robtpaton wants to merge 1 commit into
nodejs:masterfrom
robtpaton:pipelined-socket-destroy-template-literals
Closed

test: replace string concatenation in test file#15915
robtpaton wants to merge 1 commit into
nodejs:masterfrom
robtpaton:pipelined-socket-destroy-template-literals

Conversation

@robtpaton

@robtpatonrobtpaton commented Oct 6, 2017

Copy link
Copy Markdown
Contributor

This was a task from Code & Learn at NINA17.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@robtpaton
test: replace string concatenation in test-http-incoming-pipelined-so…
270da6d
…cket-destroy
This was a task from Code & Learn at NINA17.
@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@robtpaton

robtpaton commented Oct 6, 2017

Copy link
Copy Markdown
ContributorAuthor

Saw an error while running tests:

Error: test_callback_abort at ActivityCollector.initHooks.oninit.common.mustCall (/Users/patonr02/workspace/node/test/async-hooks/test-callback-error.js:36:45)

but this is unrelated to my change, and according to a mentor may have something to do with my OS (OSX Yosemite 10.10.5)

@watilde

watilde commented Oct 6, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Let's see the test results on ci then.
ci: https://ci.nodejs.org/job/node-test-pull-request/10419/

@mscdexmscdex added the http Issues or PRs related to the http subsystem. label Oct 6, 2017
@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
@BridgeARBridgeAR self-assigned this Oct 9, 2017
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
@robtpaton@BridgeAR
test: replace string concatenation with template
66a990b
PR-URL: #15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR

BridgeAR commented Oct 9, 2017

Copy link
Copy Markdown
Member

Landed in 66a990b

Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 !

@BridgeARBridgeAR closed this Oct 9, 2017
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@robtpaton@MylesBorins
test: replace string concatenation with template
2d25a3b
PR-URL: #15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@robtpaton@addaleax
test: replace string concatenation with template
9889c74
PR-URL: nodejs/node#15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@robtpaton@MylesBorins
test: replace string concatenation with template
06519b8
PR-URL: #15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@robtpaton@MylesBorins
test: replace string concatenation with template
1aac70f
PR-URL: #15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@robtpaton@MylesBorins
test: replace string concatenation with template
4243903
PR-URL: #15915
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@watildewatildewatilde approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@BridgeARBridgeARBridgeAR approved these changes

Assignees

@BridgeARBridgeAR

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.httpIssues or PRs related to the http subsystem.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@robtpaton@watilde@BridgeAR@benjamingr@cjihrig@tniessen@mscdex@MylesBorins@Trott@nodejs-github-bot