Uh oh!
There was an error while loading. Please reload this page.
test: replace common.fixturesDir with common.fixtures - #15949
Closed
mujz wants to merge 1 commit into
Closed
Conversation
BridgeAR
approved these changes
Oct 7, 2017
BridgeAR
reviewed
Oct 7, 2017
| @@ -1,11 +1,12 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
| const { path } = require('../common/fixtures'); | |||
Member
There was a problem hiding this comment.
This is somewhat confusing because it has the same name as the path module and therefore I would normally expect it to be the path module. It would be nicer to use the fixture name here instead.
BridgeAR pushed a commit
to BridgeAR/node
that referenced
this pull request
Oct 8, 2017
PR-URL: nodejs#15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
BridgeAR
commented
Oct 8, 2017
Member
Landed in 3a26555 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
mujz
commented
Oct 11, 2017
ContributorAuthor
addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 21, 2017
PR-URL: #15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit
that referenced
this pull request
Nov 28, 2017
PR-URL: #15949 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Tobias Nießen <tniessen@tnie.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
None