Skip to content

test: removed string literal on assert.strictEqual - #16014

Closed
Saeed-Navarik wants to merge 1 commit into
nodejs:masterfrom
Saeed-Navarik:test-tls-pfx-gh-5100-regr
Closed

test: removed string literal on assert.strictEqual#16014
Saeed-Navarik wants to merge 1 commit into
nodejs:masterfrom
Saeed-Navarik:test-tls-pfx-gh-5100-regr

Conversation

@Saeed-Navarik

@Saeed-NavarikSaeed-Navarik commented Oct 6, 2017•
edited by tniessen
Loading

Copy link
Copy Markdown
Contributor

removed string literal argument to function call strictEqual
so that default error message is printed

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Oct 6, 2017
@Saeed-NavarikSaeed-Navarik changed the title test: removed msg on assert.strictEqual on test-tls-pfx-gh-5100-regrtest: removed msg on assert.strictEqualOct 6, 2017
@Saeed-NavarikSaeed-Navarik changed the title test: removed msg on assert.strictEqualtest: removed string literal on assert.strictEqualOct 6, 2017
@mscdexmscdex added the tls Issues and PRs related to the tls subsystem. label Oct 6, 2017
@joyeecheung

joyeecheung commented Oct 6, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10435/

@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 7, 2017
gibfahn
gibfahn approved these changes Oct 7, 2017
View reviewed changes

@gibfahngibfahn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, but LGTM either way.

Comment threadtest/parallel/test-tls-pfx-gh-5100-regr.js
null,
'authorizationError must be null'
null
);

@gibfahngibfahnOct 7, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be reformatted to be on one line like:

assert.strictEqual(c.authorizationError,null);

If you could push a commit to your branch that makes this change then that would be great.

@joyeecheung

joyeecheung commented Oct 7, 2017•
edited
Loading

Copy link
Copy Markdown
Member

Fixed @gibfahn 's comments and landed in 5843b2c, thanks for your contribution and welcome to Node.js!

joyeecheung pushed a commit that referenced this pull request Oct 7, 2017
@Saeed-Navarik@joyeecheung
test: remove messages in assert.strictEqual
5843b2c
PR-URL: #16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
@Saeed-Navarik@MylesBorins
test: remove messages in assert.strictEqual
1d7e1c0
PR-URL: #16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Oct 11, 2017
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@Saeed-Navarik@addaleax
test: remove messages in assert.strictEqual
81844b7
PR-URL: nodejs/node#16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
@Saeed-Navarik@MylesBorins
test: remove messages in assert.strictEqual
c81b425
PR-URL: #16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Oct 17, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
@Saeed-Navarik@MylesBorins
test: remove messages in assert.strictEqual
c308a30
PR-URL: #16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
@Saeed-Navarik@MylesBorins
test: remove messages in assert.strictEqual
968cc44
PR-URL: #16014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorinsMylesBorins mentioned this pull request Nov 3, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingrbenjamingrbenjamingr approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.testIssues and PRs related to the tests.tlsIssues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@Saeed-Navarik@joyeecheung@benjamingr@cjihrig@tniessen@gibfahn@mscdex@MylesBorins@Trott@nodejs-github-bot