Uh oh!
There was an error while loading. Please reload this page.
test: clarify assert messages - #16019
Closed
cpandrews8 wants to merge 1 commit into
Closed
Conversation
BridgeAR
approved these changes
Oct 6, 2017
| s1stream.end('Test123'); | ||
| s1stream = s1stream.sign(keyPem, 'base64'); | ||
| assert.strictEqual(s1, s1stream, 'Stream produces same output'); | ||
| assert.strictEqual(s1, s1stream, `${s1} should equal ${s1stream}`); |
Member
There was a problem hiding this comment.
Nice! The former message was actually really wrong!
lance
approved these changes
Oct 9, 2017
lance
commented
Oct 9, 2017
Member
lance
commented
Oct 9, 2017
Member
Gee whiz, the flakiness of CI can be burdensome sometimes. Looks like all CI issues are completely unrelated. Otherwise everything is green. I'm going to land this. Documenting here, just for the record. aix61-ppc64smartos15-64vs2017,win2016,03,pi3-raspbian-jessie |
lance pushed a commit
that referenced
this pull request
Oct 9, 2017
PR-URL: #16019 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
lance
commented
Oct 9, 2017
Member
Landed in 5f15fde @cpandrews8 thanks for your contribution! It's much appreciated. |
MylesBorins pushed a commit
that referenced
this pull request
Oct 11, 2017
PR-URL: #16019 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
Merged
addaleax pushed a commit
to addaleax/ayo
that referenced
this pull request
Oct 12, 2017
PR-URL: nodejs/node#16019 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 17, 2017
PR-URL: #16019 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Oct 18, 2017
PR-URL: #16019 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
MylesBorins pushed a commit
that referenced
this pull request
Oct 25, 2017
PR-URL: #16019 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Lance Ball <lball@redhat.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test