Skip to content

build: ignore empty folders in test-addons - #16031

Closed
gr2m wants to merge 1 commit into
nodejs:masterfrom
gr2m:14843/addons-test-fix
Closed

build: ignore empty folders in test-addons#16031
gr2m wants to merge 1 commit into
nodejs:masterfrom
gr2m:14843/addons-test-fix

Conversation

@gr2m

@gr2mgr2m commented Oct 6, 2017•
edited by BridgeAR
Loading

Copy link
Copy Markdown
Contributor

Fixes#14843

Thanks

@MylesBorins for mentoring <3

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 6, 2017
MylesBorins
MylesBorins approved these changes Oct 6, 2017
View reviewed changes

@MylesBorinsMylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorinsMylesBorins assigned refack and unassigned refackOct 6, 2017
mhdawson
mhdawson approved these changes Oct 6, 2017
View reviewed changes

@mhdawsonmhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TrottTrott added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Oct 6, 2017
addaleax
addaleax approved these changes Oct 7, 2017
View reviewed changes

@addaleaxaddaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 💙

@mhdawson

mhdawson commented Oct 11, 2017

Copy link
Copy Markdown
Member

ci run: https://ci.nodejs.org/job/node-test-pull-request/10627/

@mhdawsonmhdawson self-assigned this Oct 11, 2017
@mhdawson

mhdawson commented Oct 11, 2017

Copy link
Copy Markdown
Member

CI run was good landing.

@mhdawson

mhdawson commented Oct 11, 2017

Copy link
Copy Markdown
Member

Landed as 7da45f8

mhdawson pushed a commit that referenced this pull request Oct 11, 2017
@gr2m@mhdawson
build: ignore empty folders in test-addons
7da45f8
Fixes: #14843
PR-URL: #16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Fishrock123

Fishrock123 commented Oct 11, 2017

Copy link
Copy Markdown
Contributor

omg thanks this thing has plagued me for a very long time when switching branches

@gr2m
gr2m deleted the 14843/addons-test-fix branch October 11, 2017 20:52
@gr2m

gr2m commented Oct 11, 2017

Copy link
Copy Markdown
ContributorAuthor

Thank you all for your help creating my first Node.js PR and for your reviews :)

addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
@gr2m@addaleax
build: ignore empty folders in test-addons
c0b0561
Fixes: nodejs/node#14843
PR-URL: nodejs/node#16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@gr2m@targos
build: ignore empty folders in test-addons
f6c6929
Fixes: #14843
PR-URL: #16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@gr2m@targos
build: ignore empty folders in test-addons
f5c0d74
Fixes: #14843
PR-URL: #16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to addaleax/node that referenced this pull request Oct 22, 2017
@addaleax
build: ignore empty folders in test-addons-napi
30ce591
The same as nodejs#16031 except
for N-API addons.
Fixes: nodejs#13521
@addaleaxaddaleax mentioned this pull request Oct 22, 2017
Closed
2 tasks
@refack

refack commented Oct 22, 2017

Copy link
Copy Markdown
Contributor

@gr2m sorry I missed this one (C.R.A.Z.Y. notification backlog).
Congratulations 🍾 and hope to see more in the future 😉

tniessen pushed a commit that referenced this pull request Oct 29, 2017
@addaleax@tniessen
build: ignore empty folders in test-addons-napi
65d2067
The same as #16031 except
for N-API addons.
PR-URL: #16380Fixes: #13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@addaleax@gibfahn
build: ignore empty folders in test-addons-napi
293fe0e
The same as #16031 except
for N-API addons.
PR-URL: #16380Fixes: #13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@addaleax@gibfahn
build: ignore empty folders in test-addons-napi
d9cc8ee
The same as #16031 except
for N-API addons.
PR-URL: #16380Fixes: #13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@addaleax@gibfahn
build: ignore empty folders in test-addons-napi
528edb2
The same as #16031 except
for N-API addons.
PR-URL: #16380Fixes: #13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@addaleax@Qard
build: ignore empty folders in test-addons-napi
1dd85ce
The same as nodejs/node#16031 except
for N-API addons.
PR-URL: nodejs/node#16380Fixes: nodejs/node#13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@addaleax@Qard
build: ignore empty folders in test-addons-napi
55b5bd3
The same as nodejs/node#16031 except
for N-API addons.
PR-URL: nodejs/node#16380Fixes: nodejs/node#13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 15, 2017
@gr2m@MylesBorins
build: ignore empty folders in test-addons
e5d6872
Fixes: #14843
PR-URL: #16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@gr2m@MylesBorins
build: ignore empty folders in test-addons
038de21
Fixes: #14843
PR-URL: #16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@gr2m@MylesBorins
build: ignore empty folders in test-addons
de82db7
Fixes: #14843
PR-URL: #16031
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax added a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@addaleax
build: ignore empty folders in test-addons-napi
23e3591
The same as nodejs/node#16031 except
for N-API addons.
PR-URL: nodejs/node#16380Fixes: nodejs/node#13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuisbnoordhuisbnoordhuis approved these changes
@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@refackrefackAwaiting requested review from refack
+2 more reviewers
@MylesBorinsMylesBorinsMylesBorins approved these changes
@mhdawsonmhdawsonmhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@mhdawsonmhdawson

Labels

buildIssues and PRs related to build files or the CI.code-and-learnIssues related to the Code-and-Learn events and PRs submitted during the events.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

10 participants

@gr2m@mhdawson@Fishrock123@refack@bnoordhuis@jasnell@MylesBorins@addaleax@Trott@nodejs-github-bot