Skip to content

Fix --without-intl - #16250

Closed
TimothyGu wants to merge 2 commits into
masterfrom
no-icu-fix
Closed

Fix --without-intl#16250
TimothyGu wants to merge 2 commits into
masterfrom
no-icu-fix

Conversation

@TimothyGu

@TimothyGuTimothyGu commented Oct 17, 2017

Copy link
Copy Markdown
Member
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

src, benchmark

@nodejs-github-botnodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 17, 2017
@TimothyGu

TimothyGu commented Oct 17, 2017

Copy link
Copy Markdown
MemberAuthor

As if that issue needs more references: nodejs/build#419

@mscdexmscdex added i18n-api Issues and PRs related to the i18n implementation. build Issues and PRs related to build files or the CI. labels Oct 17, 2017
@TimothyGuTimothyGu mentioned this pull request Oct 17, 2017
Closed
3 tasks
@TimothyGu

TimothyGu commented Oct 17, 2017

Copy link
Copy Markdown
MemberAuthor

Oops, created a branch on nodejs/node. Correct PR: #16251

@TimothyGu
TimothyGu deleted the no-icu-fix branch October 17, 2017 06:25
@TimothyGuTimothyGu mentioned this pull request Oct 20, 2017
Closed
4 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

buildIssues and PRs related to build files or the CI.c++Issues and PRs that require attention from people who are familiar with C++.i18n-apiIssues and PRs related to the i18n implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimothyGu@mscdex@nodejs-github-bot