Release proposal: v2.0.1 by rvagg · Pull Request #1629 · nodejs/node

rvagg · 2015-05-07T19:29:22Z

I'm surprised we haven't had a flurry of "you broke my stuff!!" issues yet the issue & fix that concerns me the most is the NODE_DEPRECATED macro causing problems with older compilers, see #1626. I'd like to see the fix for this get out sooner rather than later. So I'm proposing a release in ~48 hours from now.

[7dde95a8bd] - async-wrap: remove before/after calls in init (Trevor Norris) #1614
[bd42ba056a] - async-wrap: set flags using functions (Trevor Norris) #1614
[4b2c786449] - async-wrap: pass PROVIDER as first arg to init (Trevor Norris) #1614
[84bf609fd2] - async-wrap: don't call init callback unnecessarily (Trevor Norris) #1614
[04cc03b029] - deps: update libuv to 1.5.0 (Saúl Ibarra Corretgé) #1646
[b16d9c28e8] - deps: upgrade v8 to 4.2.77.20 (Ben Noordhuis) #1639
[9ec3109272] - doc: add TC meeting 2015-04-29 minutes (Rod Vagg) #1585
[2c7206254c] - doc: fix typo in readme.md (AQNOUCH Mohammed) #1643
[71dc7152ee] - doc: fix PR link in CHANGELOG (Brian White) #1624
[b97b96d05a] - install: fix NameError (thefourtheye) #1628
[6ccbe75384] - js_stream: fix buffer index in DoWrite (Shigeki Ohtsu) #1635
[c43855c49c] - src: export the ParseEncoding function on Windows (Ivan Kozik) #1596
[8315b22390] - src: fix pedantic cpplint whitespace warnings (Ben Noordhuis) #1640
[b712af79a7] - src: fix NODE_DEPRECATED macro with old compilers (Ben Noordhuis) #1626
[2ed10f1349] - src: fix minor inefficiency in Buffer::New() call (Ben Noordhuis) #1577
[f696c9efab] - src: fix deprecated use of Buffer::New() (Ben Noordhuis) #1577
[0c8f13df8f] - tools: remove unused GuessWordSize function (thefourtheye) #1638

Fishrock123 · 2015-05-05T18:42:11Z

I suspect this will be 2.1.0 due to an upcoming libuv 1.5.0 - #1621 (comment)

(which will fix a bunch of issues in our tracker)

imyller · 2015-05-05T19:10:11Z

Well, for what it's worth:

you broke my stuff!!

rvagg · 2015-05-05T19:23:52Z

@imyller do we have issues to work on fixing for you?

imyller · 2015-05-05T19:58:09Z

@rvagg nothing unexpected for 2.0.0 :)

Just tracking non-core packages needing native module upgrades due to changes made in 2.0.0 at issue #1620

I'm maintaining OpenEmbedded packaging of io.js (meta-iojs). Embedded side tends to depend more on packages with native modules so 2.0.0 has larger impact there. serial ports, microtime, usb/hid, dtrace etc.

kkoopa · 2015-05-05T20:05:43Z

Oh, you'll love io.js 3.0 in a couple of weeks then.

silverwind · 2015-05-06T16:34:17Z

libuv 1.5.0 should happen momentarily, but no reason to delay this patch release.

Fishrock123 · 2015-05-06T16:41:15Z

Yeah, echoing @silverwind here. The io.js train is leaving the station today/tomorrow with fixes.

Fishrock123 · 2015-05-07T00:50:02Z

@rvagg updated the OP with a new commit list. Tomorrow sounds good, some nice fixes in here.

rvagg · 2015-05-07T16:23:21Z

current state of master, a few greens recently so it looks like we're getting things into shape https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/651/

also, what happened to all those windows timeouts? perhaps the libuv upgrade has helped there given that it's fixed other windows problems?

Fishrock123 · 2015-05-07T16:25:21Z

also, what happened to all those windows timeouts?

Idk jenkins switched to green and stuff became fine

~~status: Will be landing #1596 momentarily.~~ done

bricss · 2015-05-07T17:40:33Z

So, counting down for release :)

rvagg · 2015-05-07T19:24:43Z

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/652/ running that while I chase up a changelog, there's a couple of things worth expanding on in here and I don't have all the info yet. @trevnorris for the async_wrap additions in particular.

PR-URL: nodejs#1629

rvagg · 2015-05-07T19:47:50Z

converted this issue to a pull request, see attached CHANGELOG diff for proposed release notes, PTAL

PR-URL: nodejs#1629

bnoordhuis · 2015-05-07T19:52:29Z

Maybe mention here that it unbreaks the FreeBSD build.

s/changes/fixes/

PR-URL: nodejs#1629

Fishrock123 · 2015-05-07T19:54:59Z

converted this issue to a pull request

This is a thing??

LGTM otherwise though.

Fishrock123 · 2015-05-07T19:56:34Z

I don't think I've seen this CI failure before: (win2012r2) https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/652/nodes=win2012r2/tapTestReport/test.tap-709/

PR-URL: nodejs#1629

rvagg · 2015-05-07T20:04:37Z

@Fishrock123 there's an API for it, use hub to interact with it

@indutny or @bnoordhuis can you shed any light on whether the test-tls-ticket-cluster.js failure @ https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/652/nodes=win2012r2/tapTestReport/test.tap-709/ might be a concern?

rvagg · 2015-05-07T20:05:08Z

https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/653/ another one, no changes

PR-URL: nodejs#1629

rvagg · 2015-05-07T20:27:40Z

gah! test-tls-ticket-cluster.js on win2008 this time but ok on 2012, not sure what to make of this, @iojs/crypto

rvagg · 2015-05-07T20:32:32Z

rebooted the windows build servers, found a bunch of hung msbuild.exe processes on a 2012 and a 2008 machine

running again: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/654/

rvagg · 2015-05-07T20:52:57Z

only test-debug-port-from-cmdline.js failing on one windows box now, but I have bigger jenkins problems, WOE!

rvagg · 2015-05-07T21:11:12Z

OK, screw Jenkins, this is only impacting the Ubuntu 10.04 machines right now and is JDK related so I'm going to pretend the JVM isn't a thing that exists and move on with a release. Pushing ahead with tag and build now.

PR-URL: #1629

rvagg · 2015-05-07T21:14:22Z

https://jenkins-iojs.nodesource.com/job/iojs+release/63/

PR-URL: nodejs#57 Related: nodejs/node#1629 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>

mscdex added the meta Issues and PRs related to the general management of the project. label May 5, 2015

rvagg force-pushed the v2.0.1-proposal branch from 183e16f to c427aedCompare May 7, 2015 19:47

rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
2015-05-07 io.js v2.0.1 Release (PROPOSAL)
c427aed
PR-URL: nodejs#1629

rvagg force-pushed the v2.0.1-proposal branch from c427aed to 3e92b4eCompare May 7, 2015 19:48

rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
2015-05-07 io.js v2.0.1 Release (PROPOSAL)
3e92b4e
PR-URL: nodejs#1629

bnoordhuis reviewed May 7, 2015
View reviewed changes

rvagg force-pushed the v2.0.1-proposal branch from 3e92b4e to 5346c69Compare May 7, 2015 19:54

rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
2015-05-07 io.js v2.0.1 Release (PROPOSAL)
5346c69
PR-URL: nodejs#1629

rvagg force-pushed the v2.0.1-proposal branch from 5346c69 to 85c501dCompare May 7, 2015 20:03

rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
2015-05-07 io.js v2.0.1 Release (PROPOSAL)
85c501d
PR-URL: nodejs#1629

rvagg force-pushed the v2.0.1-proposal branch from 85c501d to 5481ce6Compare May 7, 2015 20:08

rvagg added a commit to rvagg/io.js that referenced this pull request May 7, 2015
2015-05-07 io.js v2.0.1 Release (PROPOSAL)
5481ce6
PR-URL: nodejs#1629

2015-05-07 io.js v2.0.1 Release (PROPOSAL)
50d5712
PR-URL: nodejs#1629

rvagg force-pushed the v2.0.1-proposal branch from 5481ce6 to 50d5712Compare May 7, 2015 20:10

rvagg added a commit that referenced this pull request May 7, 2015
2015-05-07 io.js v2.0.1 Release (PROPOSAL)
6c80e38
PR-URL: #1629

rvagg closed this May 7, 2015

Starefossen pushed a commit to Starefossen/docker-iojs that referenced this pull request May 9, 2015
Update to v2.0.1
6718699
PR-URL: nodejs#57 Related: nodejs/node#1629 Signed-off-by: Hans Kristian Flaatten <hans.kristian.flaatten@turistforeningen.no>

Starefossen mentioned this pull request May 9, 2015
Update to v2.0.1 nodejs/docker-iojs#57
Merged

Uh oh!

Uh oh!

Conversation

rvagg commented May 7, 2015

Uh oh!

Fishrock123 commented May 5, 2015

Uh oh!

imyller commented May 5, 2015

Uh oh!

rvagg commented May 5, 2015

Uh oh!

imyller commented May 5, 2015

Uh oh!

kkoopa commented May 5, 2015

Uh oh!

silverwind commented May 6, 2015

Uh oh!

Fishrock123 commented May 6, 2015

Uh oh!

Fishrock123 commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

Fishrock123 commented May 7, 2015

Uh oh!

bricss commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

bnoordhuisMay 7, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123May 7, 2015

Choose a reason for hiding this comment

Uh oh!

Fishrock123 commented May 7, 2015

Uh oh!

Fishrock123 commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

rvagg commented May 7, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants