deps: cherry-pick 37a3a15c3 from V8 upstream by fhinkel · Pull Request #16294 · nodejs/node

fhinkel · 2017-10-18T14:43:14Z

This is a backport of a fix for some V8 interceptor functions. I'd like to back port this so we can fix the vm module in Node 9. What do you think? Or should we wait until V8 64 lands regularly?

Original commit message:
[api] Intercept DefineProperty after Descriptor query

Analog to other interceptors, intercept the DefineProperty
call only after obtaining the property descriptor.

This behavior allows us to mirror calls on a sandboxed object
as it is needed in Node. See for example
#13265

Bug:
Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3
Reviewed-on: https://chromium-review.googlesource.com/725295
Reviewed-by: Andreas Haas ahaas@chromium.org
Commit-Queue: Franziska Hinkelmann franzih@chromium.org
Cr-Commit-Position: refs/heads/master@{#48683}

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
(https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)

Affected core subsystem(s)

deps

fhinkel · 2017-10-18T14:45:07Z

Depending PR #16293

jasnell

rubber stamp lgtm

bnoordhuis

LGTM but shouldn't this cook for a little while longer upstream?

fhinkel · 2017-10-18T16:24:39Z

Definitely wait a few days (I assumed review and merge would take a bit anyways). AFAIK this interceptor is not used in Chrome, so we wouldn't gain much from Canary coverage.

targos · 2017-10-19T00:13:17Z

Now that V8 6.2 has landed, we can update the embedder string instead.

Thanks! Updated

targos · 2017-10-21T04:47:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/10883/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1004/

fhinkel · 2017-10-21T06:39:37Z

@targos thanks for running the CI. FreeBSD failure looks unrelated to me:
not ok 1807 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max

targos · 2017-10-21T06:43:10Z

Indeed. FreeBSD is a known issue: #16354
Do you have an idea for the failing V8 test? https://ci.nodejs.org/job/node-test-commit-v8-linux/1004/nodes=benchmark,v8test=v8test/testReport/junit/(root)/v8tests/message_console___nohard_abort/

fhinkel · 2017-10-21T06:52:03Z

That's weird. I don't see how that would be affected by my change. Could this have come in by a different PR on which we didn't run the V8 tests? 🤔

targos · 2017-10-21T06:55:21Z

Maybe it's flaky. Let's try again: https://ci.nodejs.org/job/node-test-commit-v8-linux/1005/

fhinkel · 2017-10-21T07:12:04Z

I ran V8 6.2.414.32 with that patch and the message tests pass.

fhinkel · 2017-10-22T15:29:42Z

Looks like the V8 CI is failing on master, too. #16398. So this should be good to go.

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683}

targos · 2017-10-23T09:24:10Z

I think this can land before we figure out the issue with CI

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs#16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

fhinkel · 2017-10-23T09:52:48Z

Thanks. Landed in 801e61a

New issue for unrelated CI issues: #16398

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs/node#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs/node#16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

ofrobots · 2017-11-10T22:16:27Z

@fhinkel I suspect this wouldn't get accepted for merge back to stable upstream, but I though I'd ask.

fhinkel · 2017-11-11T09:13:58Z

@ofrobots This is not really a bug fix (interceptors are not spec'ed) but it changes API behavior. Can't merge this upstream.

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs#16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example #13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: #16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs/node#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs/node#16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs#16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs#16294 Backport-PR-URL: nodejs#16413 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example nodejs#13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: nodejs#16294 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

Original commit message: [api] Intercept DefineProperty after Descriptor query Analog to other interceptors, intercept the DefineProperty call only after obtaining the property descriptor. This behavior allows us to mirror calls on a sandboxed object as it is needed in Node. See for example #13265 Bug: Change-Id: I73b8f8908d13473939b37fb6727858d0bee6bda3 Reviewed-on: https://chromium-review.googlesource.com/725295 Reviewed-by: Andreas Haas <ahaas@chromium.org> Commit-Queue: Franziska Hinkelmann <franzih@chromium.org> Cr-Commit-Position: refs/heads/master@{#48683} PR-URL: #16294 Backport-PR-URL: #16413 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>

nodejs-github-bot added the v8 engine Issues and PRs related to the V8 dependency. label Oct 18, 2017

fhinkel mentioned this pull request Oct 18, 2017
src: use new V8 API in vm module #16293
Closed
8 tasks

fhinkel added vm Issues and PRs related to the vm subsystem. dont-land-on-v4.x labels Oct 18, 2017

jasnell approved these changes Oct 18, 2017
View reviewed changes

bnoordhuis approved these changes Oct 18, 2017
View reviewed changes

targos added this to the 9.0.0 milestone Oct 18, 2017

targos removed the v9.x label Oct 18, 2017

targos reviewed Oct 19, 2017
View reviewed changes

fhinkel force-pushed the Oct/backport-api-change branch from 43a502f to f44e65aCompare October 19, 2017 06:33

cjihrig approved these changes Oct 19, 2017
View reviewed changes

targos approved these changes Oct 19, 2017
View reviewed changes

fhinkel force-pushed the Oct/backport-api-change branch from f44e65a to 2bc63c4Compare October 23, 2017 03:52

fhinkel closed this Oct 23, 2017

jasnell mentioned this pull request Oct 30, 2017
Proposal: 2017-10-31, Version 9.0.0 (Current) #15135
Merged

MylesBorins added the backported-to-v9.x label Dec 12, 2017

Uh oh!

Uh oh!

Conversation

fhinkel commented Oct 18, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Uh oh!

fhinkel commented Oct 18, 2017

Uh oh!

jasnell left a comment

Choose a reason for hiding this comment

Uh oh!

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

fhinkel commented Oct 18, 2017

Uh oh!

targosOct 19, 2017

Choose a reason for hiding this comment

Uh oh!

fhinkelOct 19, 2017

Choose a reason for hiding this comment

Uh oh!

targos commented Oct 21, 2017

Uh oh!

fhinkel commented Oct 21, 2017

Uh oh!

targos commented Oct 21, 2017

Uh oh!

fhinkel commented Oct 21, 2017

Uh oh!

targos commented Oct 21, 2017

Uh oh!

fhinkel commented Oct 21, 2017

Uh oh!

fhinkel commented Oct 22, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

targos commented Oct 23, 2017

Uh oh!

fhinkel commented Oct 23, 2017

Uh oh!

ofrobots commented Nov 10, 2017

Uh oh!

fhinkel commented Nov 11, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

fhinkel commented Oct 18, 2017•
edited
Loading

fhinkel commented Oct 22, 2017•
edited
Loading