Skip to content

meta: add note about email sync to CONTRIBUTING.md - #16340

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:meta-sync-emails
Closed

meta: add note about email sync to CONTRIBUTING.md#16340
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:meta-sync-emails

Conversation

@vsemozhetbyt

@vsemozhetbytvsemozhetbyt commented Oct 20, 2017

Copy link
Copy Markdown
Contributor
Checklist
Affected core subsystem(s)

doc, meta

Refs: #16339 (comment)

Please, correct my wording if necessary.

@nodejs-github-botnodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 20, 2017
@vsemozhetbytvsemozhetbyt mentioned this pull request Oct 20, 2017
Closed
3 tasks
apapirovski
apapirovski approved these changes Oct 20, 2017
View reviewed changes
Comment threadCONTRIBUTING.md Outdated

@apapirovskiapapirovskiOct 20, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/Be/Please make — I think that's a bit nicer but this is a super minor nit.

@vsemozhetbytvsemozhetbytOct 20, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@vsemozhetbytvsemozhetbyt added the meta Issues and PRs related to the general management of the project. label Oct 20, 2017
gibfahn
gibfahn approved these changes Oct 20, 2017
View reviewed changes

@gibfahngibfahn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions.

Comment threadCONTRIBUTING.md Outdated

@gibfahngibfahnOct 20, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove timely, it seems a bit out of place here.

I think timely is actually an adjective, not an adverb (English - nonsense as usual).

@vsemozhetbytvsemozhetbytOct 20, 2017

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Comment threadCONTRIBUTING.md Outdated

@gibfahngibfahnOct 20, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe to contributors -> to Contributor (it's a title I think).

@vsemozhetbytvsemozhetbytOct 20, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And done.

@gireeshpunathil

gireeshpunathil commented Oct 21, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10880/

@vsemozhetbyt

vsemozhetbyt commented Oct 21, 2017

Copy link
Copy Markdown
ContributorAuthor

2 CI fails seem unrelated.

@gireeshpunathil

gireeshpunathil commented Oct 21, 2017

Copy link
Copy Markdown
Member

early-landing.

gireeshpunathil pushed a commit that referenced this pull request Oct 21, 2017
@vsemozhetbyt@gireeshpunathil
meta: add note about email sync to CONTRIBUTING.md
6d4c685
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: #16339 (comment)
@gireeshpunathil

gireeshpunathil commented Oct 21, 2017

Copy link
Copy Markdown
Member

Landed in 6d4c685

@vsemozhetbyt
vsemozhetbyt deleted the meta-sync-emails branch October 21, 2017 10:59
@vsemozhetbytvsemozhetbyt mentioned this pull request Oct 21, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
@vsemozhetbyt@MylesBorins
meta: add note about email sync to CONTRIBUTING.md
fd54d8a
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: #16339 (comment)
@vsemozhetbytvsemozhetbyt mentioned this pull request Oct 23, 2017
Closed
2 tasks
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@vsemozhetbyt@addaleax
meta: add note about email sync to CONTRIBUTING.md
542b277
PR-URL: nodejs/node#16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: nodejs/node#16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
@vsemozhetbyt@MylesBorins
meta: add note about email sync to CONTRIBUTING.md
f838b46
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: #16339 (comment)
@MylesBorinsMylesBorins mentioned this pull request Nov 21, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
@vsemozhetbyt@MylesBorins
meta: add note about email sync to CONTRIBUTING.md
72d5af5
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: #16339 (comment)
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
@vsemozhetbyt@MylesBorins
meta: add note about email sync to CONTRIBUTING.md
b0ac76d
PR-URL: #16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: #16339 (comment)
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@vsemozhetbyt@addaleax
meta: add note about email sync to CONTRIBUTING.md
7d29d4a
PR-URL: nodejs/node#16340
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Refs: nodejs/node#16339 (comment)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@targostargostargos approved these changes
@cjihrigcjihrigcjihrig approved these changes
@tniessentniessentniessen approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+4 more reviewers
@apapirovskiapapirovskiapapirovski approved these changes
@Fishrock123Fishrock123Fishrock123 approved these changes
@hiroppyhiroppyhiroppy approved these changes
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docIssues and PRs related to the documentations.metaIssues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

12 participants

@vsemozhetbyt@gireeshpunathil@apapirovski@jasnell@Fishrock123@targos@cjihrig@tniessen@hiroppy@gibfahn@MylesBorins@nodejs-github-bot