wrap_js_stream: adding test for readStop

[akaila]

Adding a test for wrap_js_stream readStop method that was skipped in coverage

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• commit message follows commit guidelines

Affected core subsystem(s)

wrap_js_stream

[apapirovski]

LGTM just some minor nits

[apapirovski]

I feel like the assert message here and in all the other instances below might be more confusing than helpful. I would just remove them and have it be the default assertion message.

Instead, comments could be added to explain all the stages of this process and what exactly is being tested.

[akaila]

Done

[apapirovski]

Could this be renamed to StreamWrap for consistency with the rest of the codebase?

[akaila]

Done

[apapirovski]

CI: https://ci.nodejs.org/job/node-test-pull-request/10982/

[apapirovski]

Landed in 9702ac5

Thanks for the contribution @akaila!

[gibfahn]

This is failing on v8.x-staging with:

Should this be backported to v8.x-staging? If yes please follow the guide and raise a backport PR, if no let me know or add the dont-land-on label.

Error: Cannot find module 'internal/wrap_js_stream'
at Function.Module._resolveFilename (module.js:534:15)
at Function.Module._load (module.js:464:25)
at Module.require (module.js:577:17)
at require (internal/module.js:11:18)
at Object.<anonymous> (/home/gib/node/test/parallel/test-wrap-js-stream-read-stop.js:6:20)
at Module._compile (module.js:633:30)
at Object.Module._extensions..js (module.js:644:10)
at Module.load (module.js:552:32)
at tryModuleLoad (module.js:495:12)
at Function.Module._load (module.js:487:3)
Command: out/Release/node --expose-internals /home/gib/node/test/parallel/test-wrap-js-stream-read-stop.js
[01:47|% 100|+ 2024|- 3]: Done make: *** [test] Error 1

[addaleax]

@gibfahn This depends on #16158, there is no point in a manual backport for this (but I can take a stab at the other PR)