Skip to content

crypto: migrate setEngine to internal/errors - #16429

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:crypto-setengine-internal-errors
Closed

crypto: migrate setEngine to internal/errors#16429
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:crypto-setengine-internal-errors

Conversation

@jasnell

@jasnelljasnell commented Oct 24, 2017

Copy link
Copy Markdown
Member

Migrate setEngine to use internal/errors, tho it's not entirely clear what conditions are required to trigger it.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@jasnelljasnell added crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. semver-major PRs that contain breaking changes and should be released in the next major version. labels Oct 24, 2017
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. errors Issues and PRs related to JavaScript errors originated in Node.js core. labels Oct 24, 2017
@jasnell

jasnell commented Oct 24, 2017

Copy link
Copy Markdown
MemberAuthor

ping @nodejs/tsc

@jasnell

jasnell commented Oct 25, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/10943/

@joyeecheung

joyeecheung commented Oct 25, 2017

Copy link
Copy Markdown
Member

CI failures should be unrelated

jasnell added a commit that referenced this pull request Oct 25, 2017
@jasnell
crypto: migrate setEngine to internal/errors
a78327f
PR-URL: #16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnell

jasnell commented Oct 25, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in a78327f

@jasnelljasnell closed this Oct 25, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
@jasnell@addaleax
crypto: migrate setEngine to internal/errors
94f9c5e
PR-URL: nodejs/node#16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@jasnell@addaleax
crypto: migrate setEngine to internal/errors
9a13038
PR-URL: nodejs/node#16429
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpincalpincalpinca approved these changes
@targostargostargos approved these changes
@joyeecheungjoyeecheungjoyeecheung approved these changes
+1 more reviewer
@ofrobotsofrobotsofrobots approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.cryptoIssues and PRs related to the crypto subsystem.errorsIssues and PRs related to JavaScript errors originated in Node.js core.semver-majorPRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jasnell@joyeecheung@ofrobots@lpinca@targos@nodejs-github-bot