Skip to content

[v8.x backport] util: expand test coverage for util.deprecate - #16430

Closed
akaila wants to merge 1 commit into
nodejs:v8.x-stagingfrom
akaila:backport-16305-to-v8.x
Closed

[v8.x backport] util: expand test coverage for util.deprecate#16430
akaila wants to merge 1 commit into
nodejs:v8.x-stagingfrom
akaila:backport-16305-to-v8.x

Conversation

@akaila

@akailaakaila commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

Backporting: #16305

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
Affected core subsystem(s)

util

@nodejs-github-botnodejs-github-bot added test Issues and PRs related to the tests. v8.x labels Oct 24, 2017
@akailaakaila closed this Oct 24, 2017
@akailaakaila reopened this Oct 24, 2017
@akaila

akaila commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Merge in other dependent changes as well.

@trivikr

trivikr commented Oct 24, 2017

Copy link
Copy Markdown
Member

@akaila Can you rebase instead of merge?
Details: https://github.com/nodejs/node/blob/63243bcb330408d511b3945c53719425d8b7abb8/deps/uv/CONTRIBUTING.md#rebase

@MylesBorins

MylesBorins commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@akaila where did you get 8ea3698 from

@akaila

akaila commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

@trivikr I did a cherry pick as required in backporting. This is not a merge or rebase.
@MylesBorins I had to make a new commit (8ea3698) since global expect error fails the test if SSL is present. I don't know how or if this is passing in master.

@akaila

akaila commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

FYI this is the test failure without the fix:

python tools/test.py -J --mode=release parallel/test-internal-util-assertCrypto
=== release test-internal-util-assertCrypto ===
Path: parallel/test-internal-util-assertCrypto
Mismatched function calls. Expected exactly 1, actual 0.
at Object.exports.mustCall (/Users/kaila/Developer/Node/test/common/index.js:499:10)
at Object.expectsError (/Users/kaila/Developer/Node/test/common/index.js:724:27)
at Object. (/Users/kaila/Developer/Node/test/parallel/test-internal-util-assertCrypto.js:7:30)
at Module._compile (module.js:612:30)
at Object.Module._extensions..js (module.js:623:10)
at Module.load (module.js:531:32)
at tryModuleLoad (module.js:494:12)
at Function.Module._load (module.js:486:3)
at Function.Module.runMain (module.js:653:10)

@apapirovski

apapirovski commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

You shouldn't include anything that is not directly related to the specific PR you're backporting, even if tests are failing. That can be solved in a separate PR if necessary. That said, error changes are semver-major so that fix doesn't seem applicable to v8.x anyway.

@akaila

akaila commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Ok I took out that commit. The only commit now is my test and its dependent code.

@MylesBorins

MylesBorins commented Oct 24, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

@apapirovski the error change in 8ea3698 is in a test, not in core... so it wouldn't be semver major

I too am very confused as to how that is passing on master

edit: @apapirovski my bad, I'm seeing that the change to error codes is in the backport.

@apapirovski

apapirovski commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@MylesBorins The issue I'm seeing is with a07981d811e2c22c57dbaf614a1caa94a34f30d4 being included here

@MylesBorins

MylesBorins commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@akaila we cannot land a07981d in v8.x as it is a semver major change. As it would appear that the backport requires the error change I'm going to go ahead and close this

My apologies for the miscommunication, thank you so much for taking the time to open this

@apapirovski

apapirovski commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@MylesBorins I think this all got very confused. 😭 This should still be open, the issue is that it includes a07981d (incorrect) alongside 82134aa (correct)

Maybe I'm missing something though...

@apapirovski

apapirovski commented Oct 24, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

The real solution here should be to backport that test but change the error being tested for, since the error is different.

`code`argumentmustbeastring

Without using the internal errors.

@akaila

akaila commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

I get it now. I will revert and modify the test and update the PR. Thanks

@MylesBorins

MylesBorins commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

hey all... common.expectsError is only for testing internal/error objects... as such I don't think this makes sense to continue with. It will be in 9.x, and the expanded coverage doesn't make sense for 8.

I will avoid closing again but I advise that we close this

@targos

targos commented Oct 24, 2017

Copy link
Copy Markdown
Member

common.expectsError should work with plain Errors too.

@apapirovski

apapirovski commented Oct 24, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

@MylesBorins Is there downside to having an extra test for util.deprecate in v8.x? Even if common.expectsError doesn't work (I think it should?), we can still use assert.throws...

@MylesBorins

MylesBorins commented Oct 24, 2017

Copy link
Copy Markdown
Contributor

@targos gtk
@apapirovski no downside

Sorry for being a party pooper, please safely ignore me

@akaila
util: expand test coverage for util.deprecate
d38a858
Test for invalid argument types passed to code on util.deprecate.
PR-URL: #16305
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@akaila

akaila commented Oct 24, 2017

Copy link
Copy Markdown
ContributorAuthor

Backported the test and corrected the error message and removed the error code. Verified it passes.

@gibfahn
gibfahnforce-pushed the v8.x-staging branch 2 times, most recently from 8ec47e5 to 61413c2CompareOctober 30, 2017 21:27
@gibfahn
gibfahnforce-pushed the v8.x-staging branch 3 times, most recently from b183192 to fc8acc8CompareOctober 30, 2017 21:42
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@akaila@gibfahn
util: expand test coverage for util.deprecate
908ba41
Test for invalid argument types passed to code on util.deprecate.
PR-URL: #16305
Backport-PR-URL: #16430
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@akaila@gibfahn
util: expand test coverage for util.deprecate
55ba1d4
Test for invalid argument types passed to code on util.deprecate.
PR-URL: #16305
Backport-PR-URL: #16430
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn

gibfahn commented Oct 31, 2017

Copy link
Copy Markdown
Member

@akaila thanks a lot for sticking with this!

Landed as 55ba1d4

@gibfahngibfahn closed this Oct 31, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@gibfahngibfahngibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@akaila@trivikr@MylesBorins@apapirovski@targos@gibfahn@nodejs-github-bot