Uh oh!
There was an error while loading. Please reload this page.
crypto: migrate timingSafeEqual to internal/errors - #16448
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
jasnell
commented
Oct 25, 2017
MemberAuthor
jasnell
commented
Oct 25, 2017
MemberAuthor
ping @nodejs/tsc |
targos
approved these changes
Oct 25, 2017
joyeecheung
approved these changes
Oct 25, 2017
jasnell
commented
Oct 25, 2017
MemberAuthor
Attempting partial test again on arm: https://ci.nodejs.org/job/node-test-binary-arm/11217/ |
jasnell
commented
Oct 25, 2017
MemberAuthor
CI looks good |
jasnell added a commit
that referenced
this pull request
Oct 26, 2017
PR-URL: #16448 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
jasnell
commented
Oct 26, 2017
MemberAuthor
Landed in eeada6c with a minor nit fixed while landing |
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Oct 26, 2017
PR-URL: nodejs/node#16448 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16448 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
crypto