Skip to content

src: use uv_stream_t, not uv_stream_s - #16512

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:libuv1607
Closed

src: use uv_stream_t, not uv_stream_s#16512
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:libuv1607

Conversation

@bnoordhuis

@bnoordhuisbnoordhuis commented Oct 26, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. dont-land-on-v4.x inspector Issues and PRs related to the V8 inspector protocol labels Oct 26, 2017
@tniessen

tniessen commented Oct 29, 2017

Copy link
Copy Markdown
Member

New CI: https://ci.nodejs.org/job/node-test-pull-request/11066/

@tniessen

tniessen commented Oct 29, 2017

Copy link
Copy Markdown
Member

Thanks Ben, landed in a4e46df!

@jasnelljasnell mentioned this pull request Oct 30, 2017
Merged
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@bnoordhuis@gibfahn
src: use uv_stream_t, not uv_stream_s
e5617d4
PR-URL: #16512
Refs: libuv/libuv#1607
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
@bnoordhuis@gibfahn
src: use uv_stream_t, not uv_stream_s
84ad50e
PR-URL: #16512
Refs: libuv/libuv#1607
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
@bnoordhuis@gibfahn
src: use uv_stream_t, not uv_stream_s
77c02aa
PR-URL: #16512
Refs: libuv/libuv#1607
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahngibfahn mentioned this pull request Oct 31, 2017
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@bnoordhuis@Qard
src: use uv_stream_t, not uv_stream_s
9438729
PR-URL: nodejs/node#16512
Refs: libuv/libuv#1607
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
@bnoordhuis@Qard
src: use uv_stream_t, not uv_stream_s
062c740
PR-URL: nodejs/node#16512
Refs: libuv/libuv#1607
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins

MylesBorins commented Nov 16, 2017

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
@bnoordhuis@addaleax
src: use uv_stream_t, not uv_stream_s
4c9031b
PR-URL: nodejs/node#16512
Refs: libuv/libuv#1607
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@addaleaxaddaleaxaddaleax approved these changes
@santigimenosantigimenosantigimeno approved these changes
@cjihrigcjihrigcjihrig approved these changes
+1 more reviewer
@danbevdanbevdanbev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.inspectorIssues and PRs related to the V8 inspector protocol

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@bnoordhuis@tniessen@MylesBorins@danbev@jasnell@addaleax@santigimeno@cjihrig@nodejs-github-bot