Uh oh!
There was an error while loading. Please reload this page.
test,lib: remove scatalogical terminology - #16599
Closed
Trott wants to merge 1 commit into
Closed
Conversation
jasnell
approved these changes
Oct 30, 2017
gireeshpunathil
approved these changes
Oct 30, 2017
mscdex
commented
Oct 30, 2017
Contributor
I think the commit message should be 'net,test: ...' ? |
lpinca
approved these changes
Oct 30, 2017
gibfahn
approved these changes
Oct 30, 2017
cjihrig
approved these changes
Oct 30, 2017
gibfahn
commented
Oct 30, 2017
Member
Also I think it's scatological not scatalogical in the commit message FWIW. |
digitalinfinity
approved these changes
Oct 30, 2017
addaleax
approved these changes
Oct 30, 2017
apapirovski
approved these changes
Oct 30, 2017
Trott
commented
Oct 31, 2017
MemberAuthor
Rebased, amended commit messages per the two nits about it, force pushed. |
jasnell pushed a commit
that referenced
this pull request
Nov 2, 2017
PR-URL: #16599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
jasnell
commented
Nov 2, 2017
Member
Landed in 2244f7d |
cjihrig pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
PR-URL: nodejs#16599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
gibfahn pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16599 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been previous efforts to remove profanity from the code base. I'm not sure if the two here were missed, slipped in afterwards, were considered mild enough to be ignored, or if it's just something that is no longer a concern.
Which is a longwinded way of me saying that it's fine with me if this one gets closed without merging.
That said, this change does make the code base mildly more professional, albeit in a superficial way.
/cc @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test lib