Uh oh!
There was an error while loading. Please reload this page.
src: remove unused includes in string_bytes.h - #16606
Closed
danbev wants to merge 1 commit into
Closed
Conversation
gireeshpunathil
approved these changes
Oct 30, 2017
XadillaX
approved these changes
Oct 30, 2017
tniessen
approved these changes
Oct 30, 2017
gibfahn
approved these changes
Oct 30, 2017
joyeecheung
left a comment
Member
There was a problem hiding this comment.
LGTM if CI is happy: https://ci.nodejs.org/job/node-test-pull-request/11090/
joyeecheung
approved these changes
Oct 30, 2017
joyeecheung
commented
Oct 30, 2017
Member
Also heads up for a rebase since #16548 is about to land |
danbevforce-pushed
the
remove-unused-include-string_bytes
branch
from
October 30, 2017 11:27
4a9ad7c to
68ee77fComparecjihrig
approved these changes
Oct 30, 2017
danbev
commented
Nov 1, 2017
ContributorAuthor
tniessen
commented
Nov 1, 2017
Member
Most (if not all) failures appear to be unrelated, VS2013 seem to fail compilation on all CI builds. |
danbev
commented
Nov 1, 2017
ContributorAuthor
Landed in 54946b6 |
danbev added a commit
that referenced
this pull request
Nov 1, 2017
PR-URL: #16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Qard pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Qard pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
cjihrig pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
PR-URL: nodejs#16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn pushed a commit
that referenced
this pull request
Nov 14, 2017
PR-URL: #16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
addaleax pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16606 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: XadillaX <admin@xcoder.in> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src