Skip to content

build: add missing comma in sources list - #16613

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:build-missing-comma-sources
Closed

build: add missing comma in sources list#16613
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:build-missing-comma-sources

Conversation

@danbev

Copy link
Copy Markdown
Contributor

This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:

Warning: Missing input files:src\tracing\trace_event.hsrc\util.h
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build

@nodejs-github-botnodejs-github-bot added the build Issues and PRs related to build files or the CI. label Oct 30, 2017
@danbev

Copy link
Copy Markdown
ContributorAuthor

@gireeshpunathil

Copy link
Copy Markdown
Member

I wonder how it was building / working so far with this issue!

@danbev

Copy link
Copy Markdown
ContributorAuthor

Triggering another CI to double check Windows failure: https://ci.nodejs.org/job/node-test-pull-request/11125/

@danbev
danbevforce-pushed the build-missing-comma-sources branch from 4688584 to 3ca202fCompareNovember 1, 2017 06:19
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbev

Copy link
Copy Markdown
ContributorAuthor
test/arm-fanned failure looks unrelated

console output:

warning: failed to remove out/Removing out/Build step 'Execute shell' marked build as failureTAP Reports Processing: STARTLooking for TAP results report in workspace using pattern: *.tapDid not find any matching files. Setting build result to FAILURE.Checking ^not okJenkins Text Finder: File set '*.tap' is emptyNotifying upstream projects of job completionFinished: FAILURE
test/windows-fanned failure looks unrelated

console output:

Resetting working tree > git reset --hard # timeout=10 > git clean -fdx # timeout=10[node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins4777955810906737101.batc:\workspace\node-test-binary-windows>echo off Wed 11/01/2017 4:03:40.35c:\workspace\node-test-binary-windows>tasklist | grep node || truec:\workspace\node-test-binary-windows>exit 0 [node-test-binary-windows] $ cmd /c call C:\Users\ADMINI~1\AppData\Local\Temp\1\jenkins2702603836202563709.batc:\workspace\node-test-binary-windows>TASKKILL /F /IM node.exe /T || TRUEERROR: The process "node.exe" not found.c:\workspace\node-test-binary-windows>TASKKILL /F /IM cctest.exe /T || TRUEERROR: The process "cctest.exe" not found.c:\workspace\node-test-binary-windows>TASKKILL /F /IM run-tests.exe /T || TRUEERROR: The process "run-tests.exe" not found.c:\workspace\node-test-binary-windows>TASKKILL /F /IM yes.exe /T || TRUEERROR: The process "yes.exe" not found.c:\workspace\node-test-binary-windows>git checkout -f refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013 error: pathspec 'refs/remotes/jenkins_tmp/jenkins-node-test-commit-windows-fanned-13053-binary-windows/win-vs2013' did not match any file(s) known to git.c:\workspace\node-test-binary-windows>if 1 NEQ 0 exit /b 1 Build step 'Execute Windows batch command' marked build as failureTAP Reports Processing: STARTLooking for TAP results report in workspace using pattern: *.tapDid not find any matching files. Setting build result to FAILURE.Checking ^not okJenkins Text Finder: File set '*.tap' is emptyNotifying upstream projects of job completionFinished: FAILURE

@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in 18df171

@danbevdanbev closed this Nov 1, 2017
danbev added a commit that referenced this pull request Nov 1, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
PR-URL: #16613
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@danbev
danbev deleted the build-missing-comma-sources branch November 1, 2017 08:33
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
PR-URL: nodejs/node#16613
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
PR-URL: nodejs#16613
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@cjihrigcjihrig mentioned this pull request Nov 6, 2017
@refack

Copy link
Copy Markdown
Contributor

I wonder how it was building / working so far with this issue!

Since these are .h files they are only used for change tracking, they are not actually compiled.
But this might explain why MSBuild is sometimes too eager to rebuild - because one of the files it's tracking will never exist.

gibfahn pushed a commit that referenced this pull request Nov 14, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
PR-URL: #16613
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
This commit adds a missing comma in the sources list. This effects at
least window which produces the following warning where trace_event.h
and src/util.h are concatenated:
Warning: Missing input files:
src\tracing\trace_event.hsrc\util.h
PR-URL: nodejs/node#16613
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@danbev@gireeshpunathil@refack@apapirovski@cjihrig@joyeecheung@JungMinu@richardlau@daxlab@gibfahn@MylesBorins@nodejs-github-bot