tools?: refactor test-npm into shell script

[Fishrock123]

As suggested, test-npm now resides in a separate script file, and makes a copy of deps/npm to run the tests on.

R=@othiym23 / @iojs/build / @evanlucas

[Fishrock123]

perhaps this stanza could be improved, but I'm not so sure how?

[chrisdickinson]

As a script, if I'm not mistaken you can just export npm_config_cache="bloo-blee-bloo" and it won't affect the outer environment. Then you can un-chain the cli runs, since set -e is enabled.

[Fishrock123]

As a script, if I'm not mistaken you can just export npm_config_cache="bloo-blee-bloo" and it won't affect the outer environment.

Ok, not sure if this is the best to check but make test-npm && printenv didn't see anything new.

Then you can un-chain the cli runs, since set -e is enabled.

I don't think I understand, why wouldn't that work without set -e?

[jbergstroem]

Shell script looks good to me. Quick question, the output of test-npm looks very verbose. Is this needed/intentional? If we were to use stdout from jenkins as a tap provider we need to do something about it.

[Fishrock123]

If we were to use stdout from jenkins as a tap provider we need to do something about it.

Those could be some good next steps, yes. Currently it just prints out everything that ./npm run-script test-all outputs.

Some of it is already (parsed) tap output, the rest could probably be tap-ified on npm's end.

[Fishrock123]

@jbergstroem actually that might just be npm installing it's devDependencies. I'll take a look tomorrow.

[jbergstroem]

@Fishrock123 also, I seem to get these artefacts as a result of make test-npm:

/Volumes/sink/io.js ±remotes/iojs/pr/1562 $ git status
HEAD detached at iojs/pr/1562
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git checkout -- <file>..." to discard changes in working directory)
modified: deps/npm/test/fixtures/config/userconfig-with-gc
Untracked files:
(use "git add <file>..." to include in what will be committed)
deps/npm/node_modules/.bin/

..that userconfig looks like a bug?

[Fishrock123]

@jbergstroem currently, yes. This patch resolves that, please try it. :)

(userconfig is just a shortcoming in npm's tests..)

[jbergstroem]

@Fishrock123 ah, I probably didn't pull your latest update. I'll try again.

Edit: Typo in checkout.. see above (s/1562/1662/g 😭) Looks all good.

[evanlucas]

LGTM

[Fishrock123]

Updated the NODE_EXE check to if [ -z $NODE_EXE ]; then, ptal, landing after this review.

[Fishrock123]

I can't seem to call the script by itself with a NODE_EXE and have it work, any idea why running it from make works, but without doesn't?

[jbergstroem]

@Fishrock123 works for me:

$ NODE_EXE=./iojs tools/test-npm.sh
npm WARN prefer global marked@0.3.3 should be installed with -g
npm WARN engine follow@0.11.4: wanted: {"node":"0.10.x || 0.8.x"} (current: {"node":"2.0.1","npm":"2.9.0"})
require-inject@1.2.0 node_modules/require-inject
<snip>

[Fishrock123]

Doh. I was trying to do NODE_EXE=./node without thinking about it. >_<

[Fishrock123]

Fixes #1549