Uh oh!
There was an error while loading. Please reload this page.
http2: refactor settings handling - #16668
Closed
jasnell wants to merge 1 commit into
Closed
Conversation
sebdeckers
approved these changes
Nov 1, 2017
sebdeckers
left a comment
Contributor
There was a problem hiding this comment.
This is above my pay grade, but LGTM. 😜
apapirovski
approved these changes
Nov 1, 2017
jasnell
commented
Nov 2, 2017
MemberAuthor
jasnellforce-pushed
the
http2-settings-refactor
branch
from
November 2, 2017 06:03
8a644c8 to
57a18d2CompareAdd `Http2Seettings` utility class for handling settings logic and reducing code duplication.
jasnellforce-pushed
the
http2-settings-refactor
branch
from
November 3, 2017 17:14
57a18d2 to
18b3123Comparejasnell added a commit
that referenced
this pull request
Nov 3, 2017
Add `Http2Seettings` utility class for handling settings logic and reducing code duplication. PR-URL: #16668 Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
jasnell
commented
Nov 3, 2017
MemberAuthor
Landed in de24602 |
cjihrig pushed a commit
to cjihrig/node
that referenced
this pull request
Nov 6, 2017
Add `Http2Seettings` utility class for handling settings logic and reducing code duplication. PR-URL: nodejs#16668 Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
gibfahn pushed a commit
that referenced
this pull request
Nov 14, 2017
Add `Http2Seettings` utility class for handling settings logic and reducing code duplication. PR-URL: #16668 Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
Http2Seettingsutility class for handling settings logic and reducing code duplication.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http2