Skip to content

build: add missing options to help message - #16707

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:vcbuild-help
Closed

build: add missing options to help message#16707
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:vcbuild-help

Conversation

@danbev

Copy link
Copy Markdown
Contributor

This commit add missing options to the Windows help message and
removes options that no longer exist (test-uv).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, windows

This commit add missing options to the Windows help message and
removes options that no longer exist (test-uv).
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Nov 3, 2017
danbev added a commit that referenced this pull request Nov 8, 2017
This commit add missing options to the Windows help message and
removes options that no longer exist (test-uv).
PR-URL: #16707
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in 71e7366

@danbevdanbev closed this Nov 8, 2017
@danbev
danbev deleted the vcbuild-help branch November 8, 2017 04:57
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
This commit add missing options to the Windows help message and
removes options that no longer exist (test-uv).
PR-URL: #16707
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
@MylesBorins

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging or v8.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants

@danbev@MylesBorins@bnoordhuis@jasnell@cjihrig@gireeshpunathil@BethGriggs@nodejs-github-bot