Uh oh!
There was an error while loading. Please reload this page.
build: include src\tracing when linting on win - #16720
Closed
danbev wants to merge 1 commit into
Closed
Conversation
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does.
jasnell
approved these changes
Nov 3, 2017
Idenix
commented
Nov 5, 2017
via email
bonsoir
2017-11-03 17:59 GMT+01:00 James M Snell <notifications@github.com>: … ***@***.**** approved this pull request.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#16720 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVYMKeEdwF72TARZxweV8d57nAbL84WIks5sy0aJgaJpZM4QROyd>
.
|
danbev
commented
Nov 8, 2017
ContributorAuthor
danbev
commented
Nov 8, 2017
ContributorAuthor
test/arm-fanned failure looks unrelatedReinitialized existing Git repository in /home/iojs/build/workspace/node-test-binary-arm/.git/+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/master:refs/remotes/reference/master +refs/heads/v4.x-staging:refs/remotes/reference/v4.x-staging +refs/heads/v6.x-staging:refs/remotes/reference/v6.x-staging +refs/heads/v7.x-staging:refs/remotes/reference/v7.x-staging +refs/heads/v8.x-staging:refs/remotes/reference/v8.x-stagingfatal: Couldn't find remote ref refs/heads/v7.x-stagingfatal: The remote end hung up unexpectedlyreal 0m13.370suser 0m0.110ssys 0m0.100s+ echo 'Problem fetching the shared reference repo.'Problem fetching the shared reference repo.+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmpFrom file:///home/iojs/.ccache/node.shared.reference + 86687d80ff...64bed96866 jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6 -> jenkins_tmp (forced update)real 0m42.005suser 0m17.810ssys 0m5.630s+ rm -f ****+ git checkout -f refs/remotes/jenkins_tmpWarning: you are leaving 2 commits behind, not connected toany of your branches: 86687d80ff added binaries 9213800a13 deps: ICU 60 bumpIf you want to keep them by creating a new branch, this may be a good timeto do so with: git branch <new-branch-name> 86687d80ffHEAD is now at 64bed96866... added binariesreal 0m37.907suser 0m4.160ssys 0m23.050s+ git reset --hardHEAD is now at 64bed96866 added binariesreal 0m12.236suser 0m3.520ssys 0m3.090s+ git clean -fdxwarning: failed to remove out/Release/.nfs00000000002bfbf000000113: Device or resource busyRemoving config.gypiRemoving icu_config.gypiRemoving nodeRemoving out/Release/nodeRemoving out/Release/openssl-cliRemoving test.tapRemoving test/.tmp.0/Removing test/abort/testcfg.pycRemoving test/addons-napi/testcfg.pycRemoving test/addons/testcfg.pycRemoving test/async-hooks/testcfg.pycRemoving test/doctool/testcfg.pycRemoving test/es-module/testcfg.pycRemoving test/gc/testcfg.pycRemoving test/internet/testcfg.pycRemoving test/known_issues/testcfg.pycRemoving test/message/testcfg.pycRemoving test/parallel/testcfg.pycRemoving test/pseudo-tty/testcfg.pycRemoving test/pummel/testcfg.pycRemoving test/sequential/testcfg.pycRemoving test/testpy/__init__.pycRemoving test/tick-processor/testcfg.pycRemoving test/timers/testcfg.pycRemoving tools/test.pycRemoving tools/utils.pycBuild step 'Execute shell' marked build as failureTAP Reports Processing: STARTLooking for TAP results report in workspace using pattern: *.tapDid not find any matching files. Setting build result to FAILURE.Checking ^not okJenkins Text Finder: File set '*.tap' is emptyNotifying upstream projects of job completionFinished: FAILURE |
ContributorAuthor
cc @nodejs/platform-windows |
Trott
commented
Nov 8, 2017
Member
The problematic Raspberry Pi host has been disabled. Here's a re-run of Raspberry Pi CI: https://ci.nodejs.org/job/node-test-binary-arm/11625/ |
danbev
commented
Nov 9, 2017
ContributorAuthor
Landed in f002c3d |
danbev added a commit
that referenced
this pull request
Nov 9, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit
that referenced
this pull request
Nov 13, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
commented
Nov 17, 2017
Contributor
Should this be backported to |
danbev added a commit
to danbev/node
that referenced
this pull request
Nov 21, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: nodejs#16720 PR-URL: nodejs#16720 Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 26, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: #16720 Backport-PR-URL: #17172 PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 28, 2017
This commit excludes src\tracing\trace_event.h and src\tracing\trace_event_common.h from the linter but allows the rest of the files in src\tracing to be examined by the linter which is similar to what the Makefile does. Refs: #16720 Backport-PR-URL: #17172 PR-URL: #16720 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build, windows