Skip to content

build: include src\tracing when linting on win - #16720

Closed
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:windows-lint-include-tracing
Closed

build: include src\tracing when linting on win#16720
danbev wants to merge 1 commit into
nodejs:masterfrom
danbev:windows-lint-include-tracing

Conversation

@danbev

Copy link
Copy Markdown
Contributor

This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

build, windows

This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
@nodejs-github-botnodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Nov 3, 2017
@Idenix

Idenix commented Nov 5, 2017 via email

Copy link
Copy Markdown

@danbev

Copy link
Copy Markdown
ContributorAuthor

@danbev

Copy link
Copy Markdown
ContributorAuthor
test/arm-fanned failure looks unrelated

console output:

Reinitialized existing Git repository in /home/iojs/build/workspace/node-test-binary-arm/.git/+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/master:refs/remotes/reference/master +refs/heads/v4.x-staging:refs/remotes/reference/v4.x-staging +refs/heads/v6.x-staging:refs/remotes/reference/v6.x-staging +refs/heads/v7.x-staging:refs/remotes/reference/v7.x-staging +refs/heads/v8.x-staging:refs/remotes/reference/v8.x-stagingfatal: Couldn't find remote ref refs/heads/v7.x-stagingfatal: The remote end hung up unexpectedlyreal	0m13.370suser	0m0.110ssys	0m0.100s+ echo 'Problem fetching the shared reference repo.'Problem fetching the shared reference repo.+ git fetch --no-tags file:///home/iojs/.ccache/node.shared.reference +refs/heads/jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6:refs/remotes/jenkins_tmpFrom file:///home/iojs/.ccache/node.shared.reference + 86687d80ff...64bed96866 jenkins-node-test-commit-arm-fanned-12403-binary-pi1p/cc-armv6 -> jenkins_tmp (forced update)real	0m42.005suser	0m17.810ssys	0m5.630s+ rm -f ****+ git checkout -f refs/remotes/jenkins_tmpWarning: you are leaving 2 commits behind, not connected toany of your branches: 86687d80ff added binaries 9213800a13 deps: ICU 60 bumpIf you want to keep them by creating a new branch, this may be a good timeto do so with: git branch <new-branch-name> 86687d80ffHEAD is now at 64bed96866... added binariesreal	0m37.907suser	0m4.160ssys	0m23.050s+ git reset --hardHEAD is now at 64bed96866 added binariesreal	0m12.236suser	0m3.520ssys	0m3.090s+ git clean -fdxwarning: failed to remove out/Release/.nfs00000000002bfbf000000113: Device or resource busyRemoving config.gypiRemoving icu_config.gypiRemoving nodeRemoving out/Release/nodeRemoving out/Release/openssl-cliRemoving test.tapRemoving test/.tmp.0/Removing test/abort/testcfg.pycRemoving test/addons-napi/testcfg.pycRemoving test/addons/testcfg.pycRemoving test/async-hooks/testcfg.pycRemoving test/doctool/testcfg.pycRemoving test/es-module/testcfg.pycRemoving test/gc/testcfg.pycRemoving test/internet/testcfg.pycRemoving test/known_issues/testcfg.pycRemoving test/message/testcfg.pycRemoving test/parallel/testcfg.pycRemoving test/pseudo-tty/testcfg.pycRemoving test/pummel/testcfg.pycRemoving test/sequential/testcfg.pycRemoving test/testpy/__init__.pycRemoving test/tick-processor/testcfg.pycRemoving test/timers/testcfg.pycRemoving tools/test.pycRemoving tools/utils.pycBuild step 'Execute shell' marked build as failureTAP Reports Processing: STARTLooking for TAP results report in workspace using pattern: *.tapDid not find any matching files. Setting build result to FAILURE.Checking ^not okJenkins Text Finder: File set '*.tap' is emptyNotifying upstream projects of job completionFinished: FAILURE

@danbev

danbev commented Nov 8, 2017

Copy link
Copy Markdown
ContributorAuthor

cc @nodejs/platform-windows

@Trott

Trott commented Nov 8, 2017

Copy link
Copy Markdown
Member

The problematic Raspberry Pi host has been disabled. Here's a re-run of Raspberry Pi CI: https://ci.nodejs.org/job/node-test-binary-arm/11625/

@danbev

Copy link
Copy Markdown
ContributorAuthor

Landed in f002c3d

@danbevdanbev closed this Nov 9, 2017
danbev added a commit that referenced this pull request Nov 9, 2017
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
@danbev
danbev deleted the windows-lint-include-tracing branch November 9, 2017 13:45
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins

Copy link
Copy Markdown
Contributor

Should this be backported to v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label.

danbev added a commit to danbev/node that referenced this pull request Nov 21, 2017
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
Refs: nodejs#16720
PR-URL: nodejs#16720
Reviewed-By: James M Snell <jasnell@gmail.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
MylesBorins pushed a commit that referenced this pull request Nov 26, 2017
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
Refs: #16720
Backport-PR-URL: #17172
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
This commit excludes src\tracing\trace_event.h and
src\tracing\trace_event_common.h from the linter but allows the
rest of the files in src\tracing to be examined by the linter
which is similar to what the Makefile does.
Refs: #16720
Backport-PR-URL: #17172
PR-URL: #16720
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorinsMylesBorins mentioned this pull request Nov 28, 2017
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

buildIssues and PRs related to build files or the CI.windowsIssues and PRs related to the Windows platform.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@danbev@Idenix@Trott@MylesBorins@jasnell@nodejs-github-bot