Uh oh!
There was an error while loading. Please reload this page.
deps: cherry-pick e7f4e9e from upstream libuv - #16724
Conversation
Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: nodejs#16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> fixes: nodejs#16603
MylesBorins
commented
Nov 3, 2017
I would like to see this patch land ASAP so we can land on 9.x, 8.x, 6.x and test over the weekend |
bnoordhuis
left a comment
There was a problem hiding this comment.
LGTM, I guess, but I'm old and set in my ways: why float a patch when we can just upgrade libuv wholesale?
cjihrig
commented
Nov 3, 2017
@bnoordhuis I'm guessing since this will go into an LTS release almost immediately. If we release 1.16.0 and update to that, there is a chance of other regressions going directly into v6. |
bnoordhuis
commented
Nov 3, 2017
That makes sense, and I'm okay with it because it's Windows. Floating a UNIX fix as a patch however means distro builds miss out on it because they link to libuv.so, not our bundled copy. What I mean to say is, let's not turn it into a new tradition. |
cjihrig
commented
Nov 3, 2017
Good point, as usual.
Completely agree. |
MylesBorins
commented
Nov 3, 2017
@cjihrig@bnoordhuis if y'all want to cut a 1.15.1 with this patch I'd be more than happy to do a more official upgrade. Open to whatever y'all think it best |
cjihrig
commented
Nov 3, 2017
In this case I think I'd rather just go with a cherry-pick. I'll likely be doing a full 1.16.0 release early next week and updating Node with that. |
MylesBorins
commented
Nov 3, 2017
CI against rebased master: https://ci.nodejs.org/job/node-test-pull-request/11181/ if this is green I plan to land on master, 9.x-staging, 8.x-staging, and 6.x-staging /cc @nodejs/tsc @nodejs/lts please lmk if you have any objects to landing quickly |
gibfahn
commented
Nov 3, 2017
+1 to landing quickly. |
MylesBorins
commented
Nov 4, 2017
landed in 92f8663 |
Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: #16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #16724Fixes: #16603 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: #16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #16724Fixes: #16603 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: #16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #16724Fixes: #16603 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Original commit message: tty, win: get SetWinEventHook pointer at startup SetWinEventHook is not available on some Windows versions. Fixes: #16603 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> PR-URL: #16724Fixes: #16603 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins
commented
Nov 4, 2017
landed on v9.x-staging, v8.x-staging, and v6.x-staging |
Original commit message:
tty, win: get SetWinEventHook pointer at startup
fixes: #16603
A change in libuv has broken the ability to compile node in Windows NanoServer container. Floating this patch fixes it 🎉