Skip to content

http2: multiple smaller code cleanups - #16764

Closed
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-small-improvements
Closed

http2: multiple smaller code cleanups#16764
jasnell wants to merge 1 commit into
nodejs:masterfrom
jasnell:http2-small-improvements

Conversation

@jasnell

@jasnelljasnell commented Nov 5, 2017

Copy link
Copy Markdown
Member
  • Add Http2Priority utility class
  • Reduces some code duplication
  • Other small minor cleanups
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

http2

@jasnell
http2: multiple smaller code cleanups
55d5819
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups
@nodejs-github-botnodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 5, 2017
@mscdexmscdex added the http2 Issues or PRs related to the http2 subsystem. label Nov 5, 2017
apapirovski
apapirovski approved these changes Nov 5, 2017
View reviewed changes

@apapirovskiapapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasnell

jasnell commented Nov 12, 2017

Copy link
Copy Markdown
MemberAuthor

CI: https://ci.nodejs.org/job/node-test-pull-request/11366/

jasnell added a commit that referenced this pull request Nov 12, 2017
@jasnell
http2: multiple smaller code cleanups
36e9574
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups
PR-URL: #16764
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@jasnell

jasnell commented Nov 12, 2017

Copy link
Copy Markdown
MemberAuthor

Landed in 36e9574

@jasnelljasnell closed this Nov 12, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@jasnell@evanlucas
http2: multiple smaller code cleanups
8dfd5a5
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups
PR-URL: #16764
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@jasnell@MylesBorins
http2: multiple smaller code cleanups
29efb02
* Add Http2Priority utility class
* Reduces some code duplication
* Other small minor cleanups
PR-URL: #16764
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@apapirovskiapapirovskiapapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++Issues and PRs that require attention from people who are familiar with C++.http2Issues or PRs related to the http2 subsystem.lib / srcIssues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jasnell@apapirovski@mscdex@MylesBorins@nodejs-github-bot