Uh oh!
There was an error while loading. Please reload this page.
test: move test-http-keepalive-maxsockets to sequential - #16777
Closed
Trott wants to merge 1 commit into
Closed
Conversation
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential.
apapirovski
approved these changes
Nov 5, 2017
Contributor
Why does it fail? It's not using a shared port? If it's the |
Trott
commented
Nov 5, 2017
MemberAuthor
=== release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 1 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:54:14) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js[00:06|% 100|+ 31|- 1]: Done
$ tools/test.py -j 32 --repeat 32 test/parallel/test-http-keepalive-maxsockets.js === release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 0 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js=== release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 1 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js=== release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 0 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js=== release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 1 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:54:14) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js=== release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 0 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:46:12) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js=== release test-http-keepalive-maxsockets === Path: parallel/test-http-keepalive-maxsocketsassert.js:42 throw new errors.AssertionError({ ^AssertionError [ERR_ASSERTION]: 1 === 2 at Timeout._onTimeout (/Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js:54:14) at ontimeout (timers.js:478:11) at tryOnTimeout (timers.js:302:5) at Timer.listOnTimeout (timers.js:262:5)Command: out/Release/node /Users/trott/io.js/test/parallel/test-http-keepalive-maxsockets.js[00:06|% 100|+ 26|- 6]: Done
$
IMO anything that needs |
refack
approved these changes
Nov 5, 2017
cjihrig
approved these changes
Nov 5, 2017
gireeshpunathil
approved these changes
Nov 6, 2017
hiroppy
approved these changes
Nov 6, 2017
jasnell
approved these changes
Nov 6, 2017
Trott
commented
Nov 7, 2017
MemberAuthor
Trott added a commit
to Trott/io.js
that referenced
this pull request
Nov 7, 2017
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential. PR-URL: nodejs#16777 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Trott
commented
Nov 7, 2017
MemberAuthor
Landed in 6af68d0 |
evanlucas pushed a commit
that referenced
this pull request
Nov 13, 2017
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential. PR-URL: #16777 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2017
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential. PR-URL: #16777 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 17, 2017
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential. PR-URL: #16777 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
MylesBorins pushed a commit
that referenced
this pull request
Nov 21, 2017
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential. PR-URL: #16777 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit
that referenced
this pull request
Nov 28, 2017
test-http-keepalive-maxsockets.js will fail if sufficient copies are run at once. Move to sequential. PR-URL: #16777 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test-http-keepalive-maxsockets.js will fail if sufficient copies are run
at once. Move to sequential.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test http