Skip to content

loader: test search module - #16795

Closed
clakech wants to merge 1 commit into
nodejs:masterfrom
clakech:loaderSearchCoverage
Closed

loader: test search module#16795
clakech wants to merge 1 commit into
nodejs:masterfrom
clakech:loaderSearchCoverage

Conversation

@clakech

@clakechclakech commented Nov 6, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX)

@nodejs-github-botnodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
@mscdexmscdex added the esm Issues and PRs related to the ECMAScript Modules implementation. label Nov 6, 2017
@joyeecheung

joyeecheung commented Nov 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11258/

1 similar comment
@joyeecheung

joyeecheung commented Nov 7, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11258/

@clakech

clakech commented Nov 7, 2017

Copy link
Copy Markdown
ContributorAuthor

@joyeecheung Hi, thanks for running the CI. The build is stuck since 5 hours. What should I do ?

@Trott

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

The build is stuck since 5 hours. What should I do ?

@clakech All the CI runs are done except an AIX host which only became available for this CI run about 10 minutes ago. Everything else passed, so I'm pretty sure the AIX host will pass too.

@Trott

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

I'm pretty sure the AIX host will pass too.

As my father used to say: "Famous last words..."

AIX failed, but it's unrelated. I opened an issue about the failure at #16859. Meanwhile, this can land.

@Trott

Trott commented Nov 7, 2017

Copy link
Copy Markdown
Member

Meanwhile, this can land.

Er, well, it should stay up for another day or two before landing. But I mean, Ci is OK. (Of course if any changes are requested and made, we'll need to re-run CI.)

@clakech

clakech commented Nov 10, 2017

Copy link
Copy Markdown
ContributorAuthor

hi @Trott, should we launch another CI build ? or it could land as is ?

@joyeecheung

joyeecheung commented Nov 12, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/11370/

jasnell pushed a commit that referenced this pull request Nov 12, 2017
@clakech@jasnell
loader: test search module
e0113ab
PR-URL: #16795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@jasnell

jasnell commented Nov 12, 2017

Copy link
Copy Markdown
Member

Landed in e0113ab

@jasnelljasnell closed this Nov 12, 2017
evanlucas pushed a commit that referenced this pull request Nov 13, 2017
@clakech@evanlucas
loader: test search module
64a0c80
PR-URL: #16795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@evanlucasevanlucas mentioned this pull request Nov 13, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Nov 17, 2017
@clakech@MylesBorins
loader: test search module
dc14c25
PR-URL: #16795
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@gibfahngibfahn mentioned this pull request Nov 21, 2017
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnelljasnelljasnell approved these changes
@lpincalpincalpinca approved these changes
@cjihrigcjihrigcjihrig approved these changes
@gireeshpunathilgireeshpunathilgireeshpunathil approved these changes
+1 more reviewer
@apapirovskiapapirovskiapapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

esmIssues and PRs related to the ECMAScript Modules implementation.testIssues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

11 participants

@clakech@joyeecheung@Trott@jasnell@apapirovski@lpinca@cjihrig@gireeshpunathil@mscdex@MylesBorins@nodejs-github-bot